Re: 2.5.3-pre5 -- "pcilynx.c:638: invalid operands to binary &" and "pcilynx.c:650: `cards' undeclared"

[Evgeniy Polyakov <johnpol@2ka.mipt.ru>]

[-- Attachment #1: Type: text/plain, Size: 1080 bytes --]

On 24 Jan 2002 20:18:26 -0800
Miles Lane <miles@megapathdsl.net> wrote:

> 
> ld -m elf_i386 -r -o ieee1394.o ieee1394_core.o ieee1394_transactions.o
> hosts.o highlevel.o csr.o nodemgr.o
> gcc -D__KERNEL__ -I/usr/src/linux/include -Wall -Wstrict-prototypes
> -Wno-trigraphs -O2 -fomit-frame-pointer -fno-strict-aliasing -fno-common
> -pipe -mpreferred-stack-boundary=2 -march=athlon  -DMODULE   -c -o
> pcilynx.o pcilynx.c
> pcilynx.c: In function `mem_open':
> pcilynx.c:638: invalid operands to binary &
> pcilynx.c:650: `num_of_cards' undeclared (first use in this function)
> pcilynx.c:650: (Each undeclared identifier is reported only once
> pcilynx.c:650: for each function it appears in.)
> pcilynx.c:650: `cards' undeclared (first use in this function)
> pcilynx.c: In function `aux_poll':
> pcilynx.c:721: `cards' undeclared (first use in this function)

Have you tried this patch?
Please apply and check if errors occure again.
And of course tell us about process.
Thanks.

btw, Dave Jones has fixed it in his tree, try to look into it.


	Evgeniy Polyakov ( s0mbre ).

[-- Attachment #2: ieee1394_pcilynx.patch --]
[-- Type: application/octet-stream, Size: 802 bytes --]

--- /tmp/pcilynx.c	Wed Jan 23 05:54:38 2002
+++ ./pcilynx.c	Wed Jan 23 06:49:50 2002
@@ -55,9 +55,15 @@
 #define PRINTD(level, card, fmt, args...) do {} while (0)
 #endif
 
+#define MAX_NUM_OF_CARDS	10 /* 
+				    *  How do you think, 
+				    * can anyone has such amount of cards 
+				    * in one computer? 
+				    */
 
 static struct hpsb_host_driver *lynx_driver;
-static unsigned int card_id;
+static unsigned int card_id, num_of_cards;
+struct ti_lynx cards[MAX_NUM_OF_CARDS];
 
 /*
  * PCL handling functions.
@@ -1509,6 +1515,11 @@
 
         hpsb_add_host(host);
         lynx->state = is_host;
+	
+	if (num_of_cards < MAX_NUM_OF_CARDS)
+		cards[num_of_cards++] = host->hostdata;
+	else
+		FAIL("Too many cards[ %d ]... Impossible...\n", num_of_cards);
 
         return 0;
 #undef FAIL