From: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
To: Miles Lane <miles@megapathdsl.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: 2.5.3-pre5 -- video1394.c:868: too few arguments to function `remap_page_range'
Date: Fri, 25 Jan 2002 12:40:31 +0300 [thread overview]
Message-ID: <20020125124031.3434a20e.johnpol@2ka.mipt.ru> (raw)
In-Reply-To: <1011932503.10907.169.camel@stomata.megapathdsl.net>
In-Reply-To: <1011932503.10907.169.camel@stomata.megapathdsl.net>
[-- Attachment #1: Type: text/plain, Size: 923 bytes --]
On 24 Jan 2002 20:21:42 -0800
Miles Lane <miles@megapathdsl.net> wrote:
>
> gcc -D__KERNEL__ -I/usr/src/linux/include -Wall -Wstrict-prototypes
> -Wno-trigraphs -O2 -fomit-frame-pointer -fno-strict-aliasing -fno-common
> -pipe -mpreferred-stack-boundary=2 -march=athlon -DMODULE -c -o
> video1394.o video1394.c
> video1394.c: In function `do_iso_mmap':
> video1394.c:868: warning: passing arg 1 of `remap_page_range' makes
> pointer from integer without a cast
> video1394.c:868: incompatible type for argument 4 of `remap_page_range'
> video1394.c:868: too few arguments to function `remap_page_range'
> make[2]: *** [video1394.o] Error 1
> make[2]: Leaving directory `/usr/src/linux/drivers/ieee1394'
It is very hard to Linus to look and apply all patches, so pre5 has the
same errors that others pre. Please, apply this patch or get it from Dave
Jones tree. I hope it will help you.
Evgeniy Polyakov ( s0mbre ).
[-- Attachment #2: ieee1394_video1394.patch --]
[-- Type: application/octet-stream, Size: 1276 bytes --]
--- ./drivers/ieee1394/video1394.c~ Tue Jan 22 05:11:08 2002
+++ ./drivers/ieee1394/video1394.c Wed Jan 23 07:04:58 2002
@@ -844,8 +844,9 @@
reg_write(ohci, OHCI1394_IsoXmitIntMaskSet, 1<<d->ctx);
}
-static int do_iso_mmap(struct ti_ohci *ohci, struct dma_iso_ctx *d,
- const char *adr, unsigned long size)
+static int do_iso_mmap(struct vm_area_struct *vma, struct ti_ohci *ohci,
+ struct dma_iso_ctx *d,
+ const char *adr, unsigned long size)
{
unsigned long start=(unsigned long) adr;
unsigned long page,pos;
@@ -865,7 +866,7 @@
pos=(unsigned long) d->buf;
while (size > 0) {
page = kvirt_to_pa(pos);
- if (remap_page_range(start, page, PAGE_SIZE, PAGE_SHARED))
+ if (remap_page_range(vma, start, page, PAGE_SIZE, PAGE_SHARED))
return -EAGAIN;
start+=PAGE_SIZE;
pos+=PAGE_SIZE;
@@ -1406,7 +1407,7 @@
if (video->current_ctx == NULL) {
PRINT(KERN_ERR, ohci->id, "Current iso context not set");
} else
- res = do_iso_mmap(ohci, video->current_ctx,
+ res = do_iso_mmap(vma, ohci, video->current_ctx,
(char *)vma->vm_start,
(unsigned long)(vma->vm_end-vma->vm_start));
unlock_kernel();
next prev parent reply other threads:[~2002-01-25 9:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-01-25 4:21 Miles Lane
2002-01-25 9:40 ` Evgeniy Polyakov [this message]
2002-01-25 17:33 ` Miles Lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020125124031.3434a20e.johnpol@2ka.mipt.ru \
--to=johnpol@2ka.mipt.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=miles@megapathdsl.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®