mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Justin T. Gibbs" <gibbs@scsiguy.com>
To: andersen@codepoet.org
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: Adaptec 1480b SlimSCSI vs hotplug
Date: Tue, 29 Jan 2002 17:48:53 -0700	[thread overview]
Message-ID: <200201300048.g0U0mrI59231@aslan.scsiguy.com> (raw)
In-Reply-To: Your message of "Tue, 29 Jan 2002 16:26:29 MST." <20020129232629.GB937@codepoet.org>

>Does this look agreeable?

The only thing you've really changed is the class_mask.  I don't
understand why testing against *more bits* of the class allows your
card to be detected.  Can you explain why the old code fail?

>--- linux-2.4.18-pre7.orig/drivers/scsi/aic7xxx/aic7xxx_linux_pci.c	Tue Jan
> 29 05:20:08 2002
>+++ linux/drivers/scsi/aic7xxx/aic7xxx_linux_pci.c	Tue Jan 29 05:20:08 200
>2
>@@ -62,12 +62,12 @@
> /* We do our own ID filtering.  So, grab all SCSI storage class devices. */
> static struct pci_device_id ahc_linux_pci_id_table[] = {
> 	{
>-		0x9004, PCI_ANY_ID, PCI_ANY_ID, PCI_ANY_ID,
>-		PCI_CLASS_STORAGE_SCSI << 8, 0xFFFF00, 0
>+		PCI_VENDOR_ID_ADAPTEC, PCI_ANY_ID, PCI_ANY_ID, PCI_ANY_ID,
>+		((PCI_CLASS_STORAGE_SCSI << 8) | 0x00), ~0, 0
> 	},
> 	{
>-		0x9005, PCI_ANY_ID, PCI_ANY_ID, PCI_ANY_ID,
>-		PCI_CLASS_STORAGE_SCSI << 8, 0xFFFF00, 0
>+		PCI_VENDOR_ID_ADAPTEC2, PCI_ANY_ID, PCI_ANY_ID, PCI_ANY_ID,
>+		((PCI_CLASS_STORAGE_SCSI << 8) | 0x00), ~0, 0
> 	},
> 	{ 0 }
> };
>
> -Erik

--
Justin

  reply	other threads:[~2002-01-30  0:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-01-29 23:26 Erik Andersen
2002-01-30  0:48 ` Justin T. Gibbs [this message]
2002-01-30  2:52   ` Erik Andersen
2002-01-30  4:53     ` Justin T. Gibbs
2002-01-31 13:19       ` Erik Andersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200201300048.g0U0mrI59231@aslan.scsiguy.com \
    --to=gibbs@scsiguy.com \
    --cc=andersen@codepoet.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®