Re: Oops on 2.4.17 possibly UMS-DOS related

[Ragnar Hojland Espinosa <ragnar@ragnar-hojland.com>]

On Tue, Jan 29, 2002 at 05:36:37PM -0500, Vince Weaver wrote:
> 
> X oopsed once on me after about a week of uptime, and now whenever I try
> to run "startx" I get the message
> 
> umsdos_lookup_x: tmp/..LINK256 negative after link
> 
> followed by the below oops.
> 
> System is slackware 8.0 with a hand-compiled stock 2.4.17 kernel,
> 64MB RAM, Pentium II 300Mhz, Matrox Millenium II graphics card.
> Filesystem is a 4GB vfat drive with umsdos running on top.  It worked fine
> until this happened... rebooting doesn't help, nor does "umssync" and I
> can't figure out which file is causing the problem (assuming it really is
> a UMS DOS problem, the decoded oops seems a bit odd, but I have made sure
> the system map file is the proper one).


Perhaps this helps?

--- linux-2.4.17/fs/umsdos/dir.c.O	Wed Jan 30 04:08:16 2002
+++ linux-2.4.17/fs/umsdos/dir.c	Wed Jan 30 04:08:43 2002
@@ -537,7 +537,7 @@ out_add:
 	ret = 0;
 
 out_dput:
-	if (dret && dret != dentry)
+	if (!IS_ERR(dret) && dret != dentry)
 		d_drop(dret);
 	dput(dret);
 out:


-- 
____/|  Ragnar Højland      Freedom - Linux - OpenGL |    Brainbench MVP
\ o.O|  PGP94C4B2F0D27DE025BE2302C104B78C56 B72F0822 | for Unix Programming
 =(_)=  "Thou shalt not follow the NULL pointer for  | (www.brainbench.com)
   U     chaos and madness await thee at its end."