Re: [PATCH] KERN_INFO for devfs

[David Weinehall <tao@acc.umu.se>]

On Wed, Jan 30, 2002 at 11:03:05AM -0200, Denis Vlasenko wrote:
> On 29 January 2002 14:49, Horst von Brand wrote:
> > > diff -u --recursive linux-2.4.18-pre6mhv_ll/fs/devfs/base.c
> > > linux-2.4.18-pre6mhv_ll.devfs/fs/devfs/base.c
> > > --- linux-2.4.18-pre6mhv_ll/fs/devfs/base.c     Fri Jan 25 15:49:53 2002
> > > +++ linux-2.4.18-pre6mhv_ll.devfs/fs/devfs/base.c       Mon Jan 28
> > > 23:05:44 2002
> > > @@ -3490,8 +3489,8 @@
> > >      int err;
> > >
> > >      if ( !(boot_options & OPTION_MOUNT) ) return;
> > > -    err = do_mount ("none", "/dev", "devfs", 0, "");
> > > -    if (err == 0) printk ("Mounted devfs on /dev\n");
> > > +    err = do_mount ("devfs", "/dev", "devfs", 0, "");
> > > +    if (err == 0) printk (KERN_INFO "Mounted devfs on /dev\n");
> > >      else printk ("Warning: unable to mount devfs, err: %d\n", err);
> >
> >                     ^^^^^
> >                      Missed this one
> 
> Hmm. KERN_WARNING can be added there, but it is the default level anyway.

Yes, but that may change (in theory, at least.) Consistency is a virtue.


/David Weinehall
  _                                                                 _
 // David Weinehall <tao@acc.umu.se> /> Northern lights wander      \\
//  Maintainer of the v2.0 kernel   //  Dance across the winter sky //
\>  http://www.acc.umu.se/~tao/    </   Full colour fire           </