From: Andi Kleen <ak@muc.de>
To: Jeff Garzik <garzik@havoc.gtf.org>
Cc: Andi Kleen <ak@muc.de>,
torvalds@transmeta.com, linux-kernel@vger.kernel.org,
davej@suse.de
Subject: Re: [PATCH] Fix rocket port driver
Date: Thu, 31 Jan 2002 02:24:13 +0100 [thread overview]
Message-ID: <20020131022413.A1628@averell> (raw)
In-Reply-To: <20020131003130.A1413@averell> <20020130201640.A18730@havoc.gtf.org>
In-Reply-To: <20020130201640.A18730@havoc.gtf.org>
On Thu, Jan 31, 2002 at 02:16:40AM +0100, Jeff Garzik wrote:
> > @@ -2042,6 +2046,10 @@
> > PCI_DEVICE_ID_RP8M, i, &bus, &device_fn))
> > if(register_PCI(count+boards_found, bus, device_fn))
> > count++;
> > + if(!pcibios_find_device(PCI_VENDOR_ID_RP,
> > + 0x8, i, &bus, &device_fn))
> > + if(register_PCI(count+boards_found, bus, device_fn))
> > + count++;
>
> Would it be possible to beg and plead and convince you to convert this
> driver to the new PCI API?
I can do that, but not tonight.
Linus, Dave, please does that not let stop you from merging my previous
patch anyways until I get to it..
>
> It hasn't been touched in ages AFAICS, and both 2.4 as well as 2.5 would
> greatly benefit from such a [tested] change.
Comtrol has a newer "beta" driver on their ftp site, but it only adds support
for some new hardware features, but doesn't change much otherwise.
-Andi
next prev parent reply other threads:[~2002-01-31 1:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-01-30 23:31 Andi Kleen
2002-01-31 1:16 ` Jeff Garzik
2002-01-31 1:24 ` Andi Kleen [this message]
2002-01-31 1:25 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020131022413.A1628@averell \
--to=ak@muc.de \
--cc=davej@suse.de \
--cc=garzik@havoc.gtf.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®