From: Jeff Garzik <garzik@havoc.gtf.org>
To: Christoph Hellwig <hch@caldera.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][RFC] kthread abstraction
Date: Fri, 1 Feb 2002 12:50:20 -0500 [thread overview]
Message-ID: <20020201125020.A25010@havoc.gtf.org> (raw)
In-Reply-To: <20020201163818.A32551@caldera.de>
In-Reply-To: <20020201163818.A32551@caldera.de>; from hch@caldera.de on Fri, Feb 01, 2002 at 04:38:19PM +0100
On Fri, Feb 01, 2002 at 04:38:19PM +0100, Christoph Hellwig wrote:
> void (*main)(struct kthread *);
>
> Mainloop of the thread. This loop is repeated until the thread
> is stopped. After finishing this method the common code calls
> schedule() so it's no allowed to have spinlocks held over more
> than one invocation.
Seems kinda nifty so far. The only comment is that I wouldn't call
schedule or anything like that. Give the thread the flexibility to
decide how it sleeps or loops. Duplicating schedule() calls is IMHO an
ok price to pay for this flexibility.
Jeff
next prev parent reply other threads:[~2002-02-01 17:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-02-01 15:38 Christoph Hellwig
2002-02-01 16:32 ` Adam Keys
2002-02-01 16:40 ` Christoph Hellwig
2002-02-01 17:21 ` Dave Hansen
2002-02-01 17:23 ` Christoph Hellwig
2002-02-01 17:49 ` Dave Hansen
2002-02-01 17:50 ` Jeff Garzik [this message]
[not found] <20020201163818.A32551@caldera.de.suse.lists.linux.kernel>
2002-02-01 16:50 ` Andi Kleen
2002-02-01 17:07 ` Christoph Hellwig
2002-02-01 17:17 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020201125020.A25010@havoc.gtf.org \
--to=garzik@havoc.gtf.org \
--cc=hch@caldera.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®