From: Francois Romieu <romieu@cogenit.fr>
To: linux-kernel@vger.kernel.org
Subject: Re: SIOCDEVICE ?
Date: Sat, 2 Feb 2002 23:18:48 +0100 [thread overview]
Message-ID: <20020202231848.A5644@fafner.intra.cogenit.fr> (raw)
In-Reply-To: <200201311304.FAA00344@adam.yggdrasil.com> <20020131181241.A3524@fafner.intra.cogenit.fr> <m3665iqhqn.fsf@defiant.pm.waw.pl> <20020202154424.A5845@fafner.intra.cogenit.fr> <20020202154348.A26147@havoc.gtf.org>
In-Reply-To: <20020202154348.A26147@havoc.gtf.org>; from garzik@havoc.gtf.org on Sat, Feb 02, 2002 at 03:43:48PM -0500
Jeff Garzik <garzik@havoc.gtf.org> :
> On Sat, Feb 02, 2002 at 03:44:24PM +0100, Francois Romieu wrote:
> > Your patch doesn't apply against 2.5.3. I did a quick update and noticed the
> > patch is the sole user of SIOCDEVICE (with dscc4) and SIOCDEVPRIVATE.
>
> SIOCDEVPRIVATE is verboten in 2.5.x, it doesn't pass through ioctl
> translation layers like that which exists on sparc64 and ia64; they are
> untyped awful interfaces.
>
> The correction would perhaps define a real command as needed...
Yes, I've seen the big fat comment in include/linux/sockios.h for
SIOCDEVPRIVATE. I can only infer that SIOCDEVICE isn't allowed any more
as it seems it sneakly escaped from the kernel sources.
<executive summary of Krzysztof Halasa's update>
The struct hdlc_device_struct offers under an union the protocol specific
(raw hdlc, frame relay, cisco, pppsync (1)) parameters of the interface.
Those are set from userspace through ifreq.ifr_settings.data and an
ifreq.ifr_settings.type of IF_PROTO_{HDLC/CISCO/FR/X25},... resp. which
specifies the size of the expected data (2).
You retrieve it from userspace with IF_GET_PROTO.
Once an interface is configured for frame-relay, pvc creation/deletion is
done with IF_PROTO_FR_{ADD/DEL}_PVC.
(1) Let's forget pppsync and it's revolting games with net_device.priv for now.
(2) ifr->ifr_settings.data_length checking duplication should be avoided imho.
</summary>
As this question was postponed until 2.5, I'd like someone to state what the
accepted api will be.
Let's hope it's not too much on-topic. :o)
--
Ueimor
next prev parent reply other threads:[~2002-02-02 22:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-01-31 13:04 linux-2.4.3/drivers/net/wan/dscc4.c does not compile Adam J. Richter
2002-01-31 17:12 ` Francois Romieu
2002-01-31 22:26 ` Krzysztof Halasa
2002-02-02 14:44 ` SIOCDEVICE ? Francois Romieu
2002-02-02 19:14 ` Krzysztof Halasa
2002-02-02 23:57 ` Jeff Garzik
2002-02-02 20:43 ` Jeff Garzik
2002-02-02 22:18 ` Francois Romieu [this message]
2002-02-03 0:40 ` Alan Cox
2002-02-03 14:19 ` Francois Romieu
2002-02-03 1:44 ` Krzysztof Halasa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020202231848.A5644@fafner.intra.cogenit.fr \
--to=romieu@cogenit.fr \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®