mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tommy Reynolds <reynolds@redhat.com>
To: "Alexander Viro" <viro@math.psu.edu>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Fix for duplicate /proc entries
Date: Fri, 8 Feb 2002 12:12:05 -0600	[thread overview]
Message-ID: <20020208121205.626d2184.reynolds@redhat.com> (raw)
In-Reply-To: <Pine.GSO.4.21.0202081251450.28514-100000@weyl.math.psu.edu>
In-Reply-To: <20020208174730.GA343@mis-mike-wstn> <Pine.GSO.4.21.0202081251450.28514-100000@weyl.math.psu.edu>

[-- Attachment #1: Type: text/plain, Size: 844 bytes --]

Uttered "Alexander Viro" <viro@math.psu.edu>, spoke thus:

> 	No point.  Check that file already exist and BUG() if it does.
> Unconditionally.  There's no need to be nice to broken code and yes,
> any code that tries to register existing procfs entry _is_ broken.
> That was never supposed to work.

Al, please confirm that your are asking Brent to reissue this patch with just
the checking and then BUG(). The current code fails but looks to the caller as
if it worked.

-- 
-- -- -- -- -- -- -- -- -- -- -- -- -- -- -- + -- -- -- -- -- -- -- -- -- --
Tommy Reynolds                               | mailto: <reynolds@redhat.com>
Red Hat, Inc., Embedded Development Services | Phone:  +1.256.704.9286
307 Wynn Drive NW, Huntsville, AL 35805 USA  | FAX:    +1.256.837.3839
Senior Software Developer                    | Mobile: +1.919.641.2923

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

  parent reply	other threads:[~2002-02-08 18:12 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-02-06  3:52 Brent Cook
2002-02-06 18:11 ` Dave Jones
2002-02-07 21:38   ` Brent Cook
2002-02-07 21:45     ` Dave Jones
2002-02-08 16:13       ` Brent Cook
2002-02-08 17:47         ` Mike Fedyk
2002-02-08 17:54           ` Alexander Viro
2002-02-08 18:12           ` Tommy Reynolds [this message]
2002-06-14 22:30       ` File permission problem with NFSv3 and 2.5.20-dj4 Brent Cook
2002-06-15 12:23         ` Dave Jones
2002-06-19 17:45           ` Brent Cook
2002-06-19 17:48             ` Dave Jones
2002-06-19 17:52             ` another sched.c error with athlon Kirk Reiser
2002-06-19 18:27               ` Adrian Bunk
2002-04-10 14:02   ` Mouse interrupts: the death knell of a VP6 Brent Cook
2002-04-10 15:23     ` Oleg Drokin
2002-04-10 16:43       ` Brent Cook
2002-04-10 16:49         ` William Park
2002-04-11  6:39           ` john slee
2002-04-10 20:55         ` Oleg Drokin
2002-04-10 17:16       ` John Adams
2002-04-10 17:52         ` Brent Cook
     [not found] <Pine.LNX.4.33.0202081203020.29252-100000@coffee.psychology.mcmaster.ca>
2002-02-08 19:26 ` Fix for duplicate /proc entries Brent Cook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020208121205.626d2184.reynolds@redhat.com \
    --to=reynolds@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@math.psu.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®