mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: pazke@orbita1.ru (Andrey Panin),
	James.Bottomley@HansenPartnership.com (James Bottomley),
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH: NEW ARCHITECTURE FOR 2.5.3] support for NCR voyager
Date: Mon, 11 Feb 2002 10:08:41 -0500	[thread overview]
Message-ID: <200202111508.g1BF8fu01678@localhost.localdomain> (raw)
In-Reply-To: Message from Alan Cox <alan@lxorguk.ukuu.org.uk>  of "Mon, 11 Feb 2002 13:41:11 GMT." <E16aGhj-0006cu-00@the-village.bc.nu>

It's historical creep.

Initially the question about being Voyager was asked immediately below 
CONFIG_MCA, which was then at the top level.  Then that got wrapped by if != 
VISW, so it ends up looking like this.

How about:

if [ "$CONFIG_VISWS" != "y" ]; then
    bool 'MCA support' CONFIG_MCA
else
    define_bool CONFIG_MCA n
fi

if [ "$CONFIG_MCA" = "y" ]; then
    bool '   Support for the NCR Voyager Architecture' CONFIG_VOYAGER
    define_bool CONFIG_X86_TSC n
fi

Actually, this also exposes a bug, the last statement should be:

if [ "$CONFIG_MCA" = "y" ]; then
    bool '   Support for the NCR Voyager Architecture' CONFIG_VOYAGER
    if [ "$CONFIG_VOYAGER" = "y"]; then
        define_bool CONFIG_X86_TSC n
    fi
fi

Since MCA machines may use the pentium TSC but voyager may not.

James



      reply	other threads:[~2002-02-11 15:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-02-08 18:25 James Bottomley
2002-02-09 18:00 ` Pavel Machek
2002-02-09 18:47   ` James Bottomley
2002-02-11  9:00 ` Andrey Panin
2002-02-11 12:05   ` Dave Jones
2002-02-11 13:41   ` Alan Cox
2002-02-11 15:08     ` James Bottomley [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200202111508.g1BF8fu01678@localhost.localdomain \
    --to=james.bottomley@hansenpartnership.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pazke@orbita1.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®