From: Timothy Ball <timball@tux.org>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: chaffee@cs.berkeley.edu, dwmw2@redhat.com, paulus@samba.org,
marcelo@conectiva.com.br
Subject: [Patch] #define foo(a) do { ... } while(0); typo fix
Date: Mon, 11 Feb 2002 13:35:47 -0500 [thread overview]
Message-ID: <20020211183547.GA1630@gwyn.tux.org> (raw)
Statements like the one in the subject shouldn't have the trailing
semicolon, it's a minor typo and I only saw it four times in my
egrep'ing so this following patch fixes it every where I saw it.
Please apply.
--timball
--snip--snip--snip--
diff -ruN linux-2.4.18-pre1-mjc2.orig/drivers/video/chipsfb.c linux-2.4.18-pre1-mjc2/drivers/video/chipsfb.c
--- linux-2.4.18-pre1-mjc2.orig/drivers/video/chipsfb.c Mon Feb 11 02:03:12 2002
+++ linux-2.4.18-pre1-mjc2/drivers/video/chipsfb.c Mon Feb 11 01:38:09 2002
@@ -79,7 +79,7 @@
} while (0)
#define read_ind(num, var, ap, dp) do { \
outb((num), (ap)); var = inb((dp)); \
-} while (0);
+} while (0)
/* extension registers */
#define write_xr(num, val) write_ind(num, val, 0x3d6, 0x3d7)
diff -ruN linux-2.4.18-pre1-mjc2.orig/fs/vfat/namei.c linux-2.4.18-pre1-mjc2/fs/vfat/namei.c
--- linux-2.4.18-pre1-mjc2.orig/fs/vfat/namei.c Mon Feb 11 01:59:39 2002
+++ linux-2.4.18-pre1-mjc2/fs/vfat/namei.c Mon Feb 11 02:06:52 2002
@@ -446,7 +446,7 @@
(x)->lower = 1; \
(x)->upper = 1; \
(x)->valid = 1; \
-} while (0);
+} while (0)
static inline unsigned char
shortname_info_to_lcase(struct shortname_info *base,
diff -ruN linux-2.4.18-pre1-mjc2.orig/include/linux/mtd/compatmac.h linux-2.4.18-pre1-mjc2/include/linux/mtd/compatmac.h
--- linux-2.4.18-pre1-mjc2.orig/include/linux/mtd/compatmac.h Mon Feb 11 01:59:57 2002
+++ linux-2.4.18-pre1-mjc2/include/linux/mtd/compatmac.h Mon Feb 11 02:13:37 2002
@@ -190,8 +190,8 @@
#if LINUX_VERSION_CODE < 0x20300
#include <linux/interrupt.h>
-#define spin_lock_bh(lock) do {start_bh_atomic();spin_lock(lock);}while(0);
-#define spin_unlock_bh(lock) do {spin_unlock(lock);end_bh_atomic();}while(0);
+#define spin_lock_bh(lock) do {start_bh_atomic();spin_lock(lock);}while(0)
+#define spin_unlock_bh(lock) do {spin_unlock(lock);end_bh_atomic();}while(0)
#else
#include <asm/softirq.h>
#include <linux/spinlock.h>
diff -ruN linux-2.4.18-pre1-mjc2.orig/include/linux/rtnetlink.h linux-2.4.18-pre1-mjc2/include/linux/rtnetlink.h
--- linux-2.4.18-pre1-mjc2.orig/include/linux/rtnetlink.h Mon Feb 11 01:59:57 2002
+++ linux-2.4.18-pre1-mjc2/include/linux/rtnetlink.h Mon Feb 11 02:14:37 2002
@@ -587,7 +587,7 @@
#define ASSERT_RTNL() do { if (down_trylock(&rtnl_sem) == 0) { up(&rtnl_sem); \
printk("RTNL: assertion failed at " __FILE__ "(%d):" __FUNCTION__ "\n", __LINE__); } \
- } while(0);
+ } while(0)
#define BUG_TRAP(x) if (!(x)) { printk("KERNEL: assertion (" #x ") failed at " __FILE__ "(%d):" __FUNCTION__ "\n", __LINE__); }
--
GPG key available on pgpkeys.mit.edu
pub 1024D/511FBD54 2001-07-23 Timothy Lu Hu Ball <timball@tux.org>
Key fingerprint = B579 29B0 F6C8 C7AA 3840 E053 FE02 BB97 511F BD54
reply other threads:[~2002-02-11 18:36 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020211183547.GA1630@gwyn.tux.org \
--to=timball@tux.org \
--cc=chaffee@cs.berkeley.edu \
--cc=dwmw2@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®