From: kuznet@ms2.inr.ac.ru
To: rusty@rustcorp.com.au (Rusty Russell)
Cc: davem@redhat.com, sfr@canb.auug.org.au, linux-kernel@vger.kernel.org
Subject: Re: Moving fasync_struct into struct file?
Date: Tue, 19 Feb 2002 22:08:11 +0300 (MSK) [thread overview]
Message-ID: <200202191908.WAA28390@ms2.inr.ac.ru> (raw)
In-Reply-To: <E16d4XU-0003VI-00@wagner.rustcorp.com.au> from "Rusty Russell" at Feb 19, 2 06:18:12 pm
Hello!
> Stephen Rothwell pointed out that if you set up SIGIO from an
> fd, fork, and exit, and PIDs wrap, the new process may be clobbered by
> the SIGIO. IMVHO the best way to clean this up is to check the
> fasync_list in sys_close, and if pid == filp->f_owner.pid and fd ==
> fasync_list->fa_fd, unregister the SIGIO.
>
> This means we need a move the "struct fasync_struct
> fasync_list" into struct file (up from all the subsystems which use
> it, eg. struct socket).
>
> See any problems with this?
I do not see.
It is a long known piece of shit in the kernel crying about repair.
I remember Al Viro planned to do something with this for 2.4,
but this has been forgotten again.
Alexey
next prev parent reply other threads:[~2002-02-19 19:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-02-19 7:18 Rusty Russell
2002-02-19 9:11 ` Alan Cox
2002-02-19 19:17 ` kuznet
2002-02-20 2:04 ` Alan Cox
2002-02-20 19:13 ` kuznet
2002-02-19 10:40 ` Bob Dunlop
2002-02-19 19:08 ` kuznet [this message]
[not found] <E16d4XU-0003VI-00@wagner.rustcorp.com.au.suse.lists.linux.kernel>
2002-02-19 9:27 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200202191908.WAA28390@ms2.inr.ac.ru \
--to=kuznet@ms2.inr.ac.ru \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®