mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: jak@rudolph.ccur.com (Joe Korty)
To: linux-kernel@vger.kernel.org
Subject: [RFC][PATCH] irq0 affinity broke on some i386 boxes
Date: Mon, 25 Feb 2002 13:56:51 -0500 (EST)	[thread overview]
Message-ID: <200202251856.SAA11120@rudolph.ccur.com> (raw)

Hi everyone,
  The following patch fixes a bug that prevents a write to
/proc/irq/0/smp_affinity from actually changing the cpu affinity
of IRQ #0, on all the (Dell server) SMP machines I have access to.

Given the wide variety of IO APIC and legacy PIC usage on various SMP
motherboards, and the nascent state of my APIC understanding, it is
quite likely that this fix is not universal.

I would like expand this patch so that IRQ0 affinity assignment works
properly on as many i386 SMP motherboards as possible.  If you have
such a motherboard, please first 1) verify that assignments to
/proc/irq/0/smp_affinity NOP for you, and 2) if it does NOP, that
this patch does or does not fix the problem on your system.

To verify that your system has the problem or not:

    in one window, run `watch -n1 cat /proc/interrupts'.

    in another window, assign some affinity value to irq0.  In the
    following example, cpu #0 (in a 4-cpu system) is to no longer get
    irq0 interrupts:

	echo e >/proc/irq/0/smp_affinity

    If your system is working properly, the watch-window should no
    longer show increments for the irq0 value for cpu0.

This patch is against 2.4.18-rc4

Joe

--- linux/arch/i386/kernel/io_apic.c.orig	Tue Nov 13 20:28:41 2001
+++ linux/arch/i386/kernel/io_apic.c	Mon Feb 25 13:17:13 2002
@@ -1537,6 +1537,7 @@
 				setup_nmi();
 				check_nmi_watchdog();
 			}
+			add_pin_to_irq(0, 0, pin2);
 			return;
 		}
 		/*

             reply	other threads:[~2002-02-25 18:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-02-25 18:56 Joe Korty [this message]
2002-03-01 17:41 ` Maciej W. Rozycki
2002-03-01 19:51   ` Joe Korty
2002-03-01 20:21     ` Maciej W. Rozycki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200202251856.SAA11120@rudolph.ccur.com \
    --to=jak@rudolph.ccur.com \
    --cc=joe.korty@ccur.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®