On Wed, Feb 27, 2002 at 12:11:44AM +1100, Stephen Rothwell wrote: > On Mon, 25 Feb 2002 16:02:52 -0800 Andrew Morton wrote: > > > > Just for the record: Both Christophe's 3c and my 3c556B > > mini-PCI NIC failed to survive APM resumes in 2.4.17. But something > > outside the 3c59x driver got fixed somewhere in the 2.4.18-pre series, > > and resume works OK in 2.4.18. > > We now notify (and wait for a response from) user mode processes about > the pending suspend BEFORE we notify the drivers. We used to do this the > other way around (which was never correct - mea culpa). > > This MAY have changed the behaviour of the drivers ... Unfortunately after a few experiments my 3c59x does not resume correctly with 2.4.18. I don't understand why but sometimes it takes a few seconds to return in a good state after a suspend/resume cycle and sometimes (at least one time) the card stay in a bad state. Would it be possible that the driver is never notified that the machine is going in a suspend mode ? When you said 'we now notify ...' the 'we' stand for apm ? Looking in the driver, the enable_wol (now I know that wol means Wake up on Lan, and I would prefer let this option disabled but it also turn on pm stuff as Andrew told me) enables few acpi call. Andrew : Is your card back immediately after resuming ? Christophe > > -- > Cheers, > Stephen Rothwell sfr@canb.auug.org.au > http://www.canb.auug.org.au/~sfr/ > - > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- Christophe Barbé GnuPG FingerPrint: E0F6 FADF 2A5C F072 6AF8 F67A 8F45 2F1E D72C B41E Thousands of years ago, cats were worshipped as gods. Cats have never forgotten this. --Anonymous