From: kuznet@ms2.inr.ac.ru
To: davem@redhat.com (David S. Miller)
Cc: raghuangadi@yahoo.com, linux-kernel@vger.kernel.org
Subject: Re: Fw: memory corruption in tcp bind hash buckets on SMP?
Date: Wed, 27 Feb 2002 22:04:25 +0300 (MSK) [thread overview]
Message-ID: <200202271904.WAA09439@ms2.inr.ac.ru> (raw)
In-Reply-To: <20020226.231934.116353439.davem@redhat.com> from "David S. Miller" at Feb 26, 2 11:19:34 pm
Hello!
> I think his analysis is alright but he patch is questionable.
Yes. "if (tb) tcp_tw_put(tw)" cannot be right, no doubts.
Seems, it is enough to remove from bind hash _before_ established.
The idea was that bind hash is pure slave of another state, so that
it need not refcounting at all. Note that adding the second increment
does not help: when we verify that leakage (the situation, when
bucket is in bind hash, but has no timer running) is impossible
we immediately arrive to elimination of the refcount.
Raghu, could you check the variant with inverted order of removal?
Do you see holes? From my side... I need to think more. :-)
Alexey
next parent reply other threads:[~2002-02-27 19:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20020226.231934.116353439.davem@redhat.com>
2002-02-27 19:04 ` kuznet [this message]
2002-02-27 19:46 ` Raghu Angadi
2002-02-27 20:05 ` Raghu Angadi
2002-02-27 20:12 ` kuznet
2002-02-27 20:31 ` Raghu Angadi
2002-03-01 19:07 ` kuznet
2002-03-04 20:48 ` Raghu Angadi
2002-03-04 23:26 ` David S. Miller
2002-03-05 0:54 ` Raghu Angadi
2002-03-05 4:30 ` David S. Miller
2002-02-27 20:08 ` Fw: " kuznet
2002-02-27 20:26 ` Raghu Angadi
2002-02-28 5:53 ` Raghu Angadi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200202271904.WAA09439@ms2.inr.ac.ru \
--to=kuznet@ms2.inr.ac.ru \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=raghuangadi@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®