From: "David S. Miller" <davem@redhat.com>
To: christopher.leech@intel.com
Cc: linux-kernel@vger.kernel.org, linux-net@vger.kernel.org
Subject: Re: hardware VLAN acceleration
Date: Thu, 28 Feb 2002 14:51:17 -0800 (PST) [thread overview]
Message-ID: <20020228.145117.101862422.davem@redhat.com> (raw)
In-Reply-To: <BD9B60A108C4D511AAA10002A50708F22C144E@orsmsx118.jf.intel.com>
In-Reply-To: <BD9B60A108C4D511AAA10002A50708F22C144E@orsmsx118.jf.intel.com>
From: "Leech, Christopher" <christopher.leech@intel.com>
Date: Thu, 28 Feb 2002 13:47:25 -0800
Is vlan_rx_kill_vid only there to ensure locking between vlan_hwaccel_rx and
unregister_802_1Q_vlan_dev? If so, could this be handled outside of the
driver?
It is there because the VLAN layer has no buisness knowing how to lock
out receive interrupt processing in your driver.
The Acenic driver, for example, uses no SMP locking at all and runs
it's RX interrupts %100 lockless requiring a global "cli()" in order
to implement vlan_rx_kill_vid().
Also, when a vlan dev is unregistered, does the driver need to know that the
vlan_group passed in to vlan_rx_register is no longer valid?
The group is still valid, groups are never destroyed by the VLAN layer
once they are created.
Franks a lot,
David S. Miller
davem@redhat.com
next prev parent reply other threads:[~2002-02-28 22:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-02-28 21:47 hardware VLAN acceleration (RE: [BETA-0.92] Third test release of Tigon3 driver) Leech, Christopher
2002-02-28 22:51 ` David S. Miller [this message]
2002-02-28 23:17 hardware VLAN acceleration Leech, Christopher
2002-02-28 23:20 ` David S. Miller
2002-02-28 23:38 Leech, Christopher
2002-02-28 23:52 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020228.145117.101862422.davem@redhat.com \
--to=davem@redhat.com \
--cc=christopher.leech@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®