mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jean Tourrilhes <jt@bougret.hpl.hp.com>
To: Maksim Krasnyanskiy <maxk@qualcomm.com>
Cc: Paul Mackerras <paulus@samba.org>,
	linux-ppp@vger.kernel.org,
	Linux kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: PPP feature request (Tx queue len + close)
Date: Tue, 5 Mar 2002 12:23:43 -0800	[thread overview]
Message-ID: <20020305122343.A1094@bougret.hpl.hp.com> (raw)
In-Reply-To: <5.1.0.14.2.20020305095825.01b61fd8@mail1.qualcomm.com> <15492.21937.402798.688693@argo.ozlabs.ibm.com> <20020304144200.A32397@bougret.hpl.hp.com> <15492.13788.572953.6546@argo.ozlabs.ibm.com> <20020304191947.A32730@bougret.hpl.hp.com> <15492.21937.402798.688693@argo.ozlabs.ibm.com> <20020305094535.A792@bougret.hpl.hp.com> <5.1.0.14.2.20020305095825.01b61fd8@mail1.qualcomm.com> <20020305102835.B847@bougret.hpl.hp.com> <5.1.0.14.2.20020305112314.01c3cea8@mail1.qualcomm.com>
In-Reply-To: <5.1.0.14.2.20020305112314.01c3cea8@mail1.qualcomm.com>; from maxk@qualcomm.com on Tue, Mar 05, 2002 at 11:39:59AM -0800

On Tue, Mar 05, 2002 at 11:39:59AM -0800, Maksim Krasnyanskiy wrote:
> 
> I looked at the code again and tried to trace TCP xmit path. Seems like it 
> should not
> back off because it does check return status of the dev_queue_xmit (send 
> packet to the driver).

	Ok. That sounds much more logical than the first explanation.

> But it does not seem to retry either. Looks like it's just waits for an ack 
> from the other side which

	Ok. The mysteries of TCP/IP implementation.

> effectively makes your window equal to 1 segment. In any case small PPP 
> queue won't make any
> good for you.

	Nope. Remember that I have buffers below PPP. The transmit
path within PPP and IrNET is minimal (no framing), so buffers in PPP
and below PPP are logically equivalent.

> >         If what you say is true, I should *increase* the buffering
> >below PPP to make sure that packet don't get dropped above PPP.
> I was under assumption that you know for sure that buffering is bad for you :)

	We are running circles. I want to reduce the amount of buffers
below TCP. This includes PPP buffers and buffers below PPP (both are
logically equivalent).
	Both of you are saying "increase buffers at PPP level and
reduce below TCP", but this doesn't make sense, and that's what I was
pointing out. You have to think on the whole stack, not each
individual component.

> >         Think about it : for TCP, it doesn't matter if buffers are
> >above or below PPP, what matter is only how many there are. TCP can't
> >make the difference between buffers at the PPP and at IrDA level.
> >         Actually, it's probably better to keep the buffers as low as
> >possible in the stack, because less processing remain to be done on
> >them before beeing transmitted.
>
> All this depends on what you want to achieve. If you're looking for max TCP
> performance. I'd recommend to use tcptrace and see what actually is going on.
> May be your RTT is to high and you need bigger windows or may be there is
> something else.

	I get 3.2 Mb/s TCP throughput over a 4Mb/s IrDA link layer, so
I'm not concernet with max performance. My question is more "how much
buffers can I trim without impacting performance". The goal is to
improve latency and decrease ressource consumption.

> Max

	Regards,

	Jean

  reply	other threads:[~2002-03-05 20:24 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-03-04 22:42 Jean Tourrilhes
2002-03-05  0:55 ` James Stevenson
2002-03-05  1:01   ` Jean Tourrilhes
2002-03-05  3:05 ` Paul Mackerras
2002-03-05  3:19   ` Jean Tourrilhes
2002-03-05 18:13     ` Maksim Krasnyanskiy
2002-03-05 18:28       ` Jean Tourrilhes
2002-03-05 19:15         ` James Carlson
2002-03-05 19:27           ` Jean Tourrilhes
2002-03-05 21:49             ` James Carlson
2002-03-05 21:17         ` Maksim Krasnyanskiy
2002-03-05 21:27           ` Jean Tourrilhes
2002-03-05  5:20   ` Paul Mackerras
2002-03-05 17:45     ` Jean Tourrilhes
2002-03-05 19:39       ` Maksim Krasnyanskiy
2002-03-05 20:23         ` Jean Tourrilhes [this message]
2002-03-05 22:48 ` Bill Davidsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020305122343.A1094@bougret.hpl.hp.com \
    --to=jt@bougret.hpl.hp.com \
    --cc=jt@hpl.hp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-ppp@vger.kernel.org \
    --cc=maxk@qualcomm.com \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®