mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Wolly <wwolly@gmx.net>
To: andrew.grover@intel.com, acpi-devel@lists.sourceforge.net
Cc: linux-kernel@vger.kernel.org
Subject: [patch] minimal ACPI bugfix
Date: Mon, 11 Mar 2002 14:31:10 +0100	[thread overview]
Message-ID: <20020311133323Z293727-890+124826@vger.kernel.org> (raw)

"Avoid creating multiple /proc entries when (buggy) ACPI
BIOS tables erroneously list both fixed- and generic-
feature buttons."
While the function already prints a disgnostic message 
on this and registers the new button dir in /proc, it fails to 
remove the old one. 

This is a trivial patch which actually does that. 
ACPI maintainer Andy, please approve that. 

Regards,
Wolly

Patch is against 2.4.18 kernel;
patched file sm_osl.c is in drivers/acpi/ospm/button/

---------------------------<patch>---------------------------
diff -u bn_osl.c bn_osl.c-patched 
--- bn_osl.c	Mon Mar 11 14:06:56 2002
+++ bn_osl.c-patched	Mon Mar 11 14:02:27 2002
@@ -96,6 +96,7 @@
 			break;
 		case BN_TYPE_FIXED:
 			printk(KERN_WARNING "ACPI: Multiple power buttons detected, ignoring fixed-feature\n");
+			remove_proc_entry(BN_PROC_POWER_BUTTON, bn_proc_root);
 		default:
 			printk(KERN_INFO "ACPI: Power Button (CM) found\n");
 			bn_power_button = BN_TYPE_GENERIC;

             reply	other threads:[~2002-03-11 13:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-03-11 13:31 Wolly [this message]
2002-03-11 18:17 Grover, Andrew

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020311133323Z293727-890+124826@vger.kernel.org \
    --to=wwolly@gmx.net \
    --cc=acpi-devel@lists.sourceforge.net \
    --cc=andrew.grover@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®