mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Adam J. Richter" <adam@yggdrasil.com>
To: alan@lxorguk.ukuu.org.uk
Cc: davej@suse.de, linux-kernel@vger.kernel.org
Subject: Re: linux-2.5.6 scsi DMA mapping and compilation fixes (not yet working)
Date: Wed, 13 Mar 2002 09:17:52 -0800	[thread overview]
Message-ID: <200203131717.JAA09703@adam.yggdrasil.com> (raw)

>[...] A general give away that you have the right one is that
>they are formatted to the linux CodingStyle document.

>Alan

	Actually, there are many indentation changes between the
NCR drivers in 2.4.18 and 2.5.6, but looking at the changes with
"diff -w" shows very few other changes, just really ancilliary
things like option parsing.

	I was a little surprised to see things like procedure
declaration lines ending in "{", which I understand confuses vi
(or some vi's).  Examples from g_NCR53C80.c include internal_setup,
generic_NCR5380_setup, generic_NCR53C400_setup, and many others.

	I believe the code in 2.5.6 is your new NCR driver,
in spite of the formatting differences.

Adam J. Richter     __     ______________   4880 Stevens Creek Blvd, Suite 104
adam@yggdrasil.com     \ /                  San Jose, California 95129-1034
+1 408 261-6630         | g g d r a s i l   United States of America
fax +1 408 261-6631      "Free Software For The Rest Of Us."

             reply	other threads:[~2002-03-13 17:18 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-03-13 17:17 Adam J. Richter [this message]
2002-03-13 17:38 ` Alan Cox
  -- strict thread matches above, loose matches on Subject: below --
2002-03-14  1:02 Adam J. Richter
2002-03-14  1:27 ` Alan Cox
2002-03-13 15:51 Adam J. Richter
2002-03-13 16:22 ` Alan Cox
2002-03-13  0:23 Adam J. Richter
2002-03-13 14:33 ` Dave Jones
2002-03-12 23:55 Adam J. Richter
2002-03-13  0:02 ` Russell King
2002-03-13 14:31   ` Dave Jones
2002-03-12 20:56 Adam J. Richter
2002-03-12 23:42 ` Russell King
2002-03-13 16:51   ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200203131717.JAA09703@adam.yggdrasil.com \
    --to=adam@yggdrasil.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=davej@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®