mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Andi Kleen <ak@suse.de>,
	davidm@hpl.hp.com, linux-kernel@vger.kernel.org,
	torvalds@transmeta.com, rth@twiddle.net
Subject: Re: [PATCH] 2.5.1-pre5: per-cpu areas
Date: Thu, 14 Mar 2002 12:14:56 +0100	[thread overview]
Message-ID: <20020314121456.A15050@wotan.suse.de> (raw)
In-Reply-To: <p73bsdrsftu.fsf@oldwotan.suse.de> <E16lT7I-0003uC-00@wagner.rustcorp.com.au>
In-Reply-To: <E16lT7I-0003uC-00@wagner.rustcorp.com.au>

On Thu, Mar 14, 2002 at 10:09:52PM +1100, Rusty Russell wrote:
> Sorry, I think one macro to get the address, one to get the contents
> is a *horrible* interface.  per_cpu() and per_cpu_ptr() or something?


It is not pretty, but I have no choice. See include/asm-x86_64/pda.h on what I 
have currently. Supporting the address in the same macro would 
double to overhead of accesing it. 

> I think you'll find that per_cpu_ptr would be fairly common, so we're
> forced into a bad interface for little gain.  You might be better off
> using another method to implement per-cpu areas.

Nope, the segment register has to stay for other reasons, and it would
be a shame to not use it for cpu data too.

I don't see it as that bad. Is it really that difficult to write _ptr
if you want the address? You can also write _noptr or _direct or whatever
if you don't want the address if you prefer that, but I want to keep
the option to do direct access even for generic code. 


-Andi

  reply	other threads:[~2002-03-14 11:15 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <15504.7958.677592.908691@napali.hpl.hp.com.suse.lists.linux.kernel>
     [not found] ` <E16lMzi-0002bb-00@wagner.rustcorp.com.au.suse.lists.linux.kernel>
2002-03-14  8:39   ` Andi Kleen
2002-03-14 11:09     ` Rusty Russell
2002-03-14 11:14       ` Andi Kleen [this message]
2002-03-14 19:48       ` H. Peter Anvin
2002-03-14 18:04   ` David Mosberger
2002-03-14 18:51     ` Andi Kleen
2002-03-15  4:07       ` Rusty Russell
2002-03-15  9:13         ` Andi Kleen
2002-03-17  7:17         ` Rusty Russell
2002-03-18  7:35           ` Andi Kleen
2002-03-19  0:02             ` Rusty Russell
2002-03-19  0:08               ` J.A. Magallon
2002-03-19  0:15               ` Andi Kleen
2002-03-19 17:05                 ` Richard Henderson
2002-03-15  4:19       ` David Mosberger
2002-03-15  5:52         ` Rusty Russell
     [not found] <15504.7958.677592.908691@napali.hpl.hp.com>
2002-03-14  4:37 ` Rusty Russell
2002-03-14  5:05   ` Jeff Garzik
2002-03-14 11:14     ` Rusty Russell
2002-03-14 11:26       ` Jeff Garzik
2002-03-14 12:16         ` Rusty Russell
2002-03-14 12:25           ` Jeff Garzik
2002-03-15  1:00         ` Richard Henderson
2002-03-14  9:37   ` Richard Henderson
2002-03-14 18:06   ` David Mosberger
2001-12-05 22:09 Rusty Russell
2001-12-06  7:21 ` Keith Owens
2001-12-06  8:07 ` David S. Miller
2001-12-06  9:18 ` Chris Wedgwood
2001-12-07 15:03   ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020314121456.A15050@wotan.suse.de \
    --to=ak@suse.de \
    --cc=davidm@hpl.hp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rth@twiddle.net \
    --cc=rusty@rustcorp.com.au \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®