mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alex Riesen <Alexander.Riesen@synopsys.com>
To: Paul Larson <plars@austin.ibm.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 2.4.19-pre3 - readv/writev should return EINVAL for count=0
Date: Thu, 21 Mar 2002 15:12:05 +0100	[thread overview]
Message-ID: <20020321151205.D1350@riesen-pc.gr05.synopsys.com> (raw)
In-Reply-To: <1016650428.2202.98.camel@plars.austin.ibm.com> <20020321083408.C1350@riesen-pc.gr05.synopsys.com> <1016717331.2202.108.camel@plars.austin.ibm.com>

may be not. SunOS, HPUX, and AIX return EINVAL (unless it's their libc).
Maybe it is useful for compatibility with read/write.
And it's not really an error, after all, whereas EINVAL also means
overflow (sum of all iovec's longer than ssize_t) for readv/writev.
-alex

On Thu, Mar 21, 2002 at 07:28:50AM -0600, Paul Larson wrote:
> On Thu, 2002-03-21 at 01:34, Alex Riesen wrote:
> > I would disagree. According to the spec "The iovcnt argument is valid
> > if greater than 0 and less than or equal to {IOV_MAX}, as defined in
> > <limits.h>" (http://www.opengroup.org/onlinepubs/007904975/).
> > The behaviour you want to achieve is described as optional, besides
> > there is programs depending on the old behaviour (of my own at least :).
> > It's very handy to skip extra zero-parameter check...
> > -alex
> ^-This is the one I was referring to.  Is there any reason for it to not
> be in compliance with this?
> "The iovcnt argument is valid if greater than 0 and less than or equal to {IOV_MAX}, as defined in
>  <limits.h>" (http://www.opengroup.org/onlinepubs/007904975/)
> 
> Sorry, I just noticed that there was a previous thread here in which a
> patch was submitted by balbir_soni@yahoo.com.  I think the same person
> who started it might have been the same person that pointed out that one
> of our LTP testcases was passing when it shouldn't be and brought it to
> my attention.  It doesn't look like that thread got resolved though.
> 
> Paul Larson

      reply	other threads:[~2002-03-21 14:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-03-20 18:53 Paul Larson
2002-03-20 23:48 ` Alan Cox
2002-03-21  7:34 ` Alex Riesen
2002-03-21 13:28   ` Paul Larson
2002-03-21 14:12     ` Alex Riesen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020321151205.D1350@riesen-pc.gr05.synopsys.com \
    --to=alexander.riesen@synopsys.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=plars@austin.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®