Re: [PATCH] matroxfb_base.c - not a so little patch

[Petr Vandrovec <vandrove@vc.cvut.cz>]

On Sat, Mar 30, 2002 at 09:40:06PM +0500, Denis Zaitsev wrote:
> On Fri, Mar 22, 2002 at 01:17:04PM +0100, Petr Vandrovec wrote:
> > On 22 Mar 02 at 16:47, Denis Zaitsev wrote:
> > > 
> > > The patch is against 2.5.5.  It seems that matroxfb_base.c is still
> > > the same since that time.  And I assume matroxfb_base.c with
> > > <if (var->bits_per_pixel == 4)> branch present, i.e. without my
> > > previous little fix.
> > 
> > Did you verified effects on generated code/data size? 
> > 
> > > +   for (p= &table[0].bpp; *p < bpp; p+= sizeof table[0]);
> > > +   var->red   .offset= *++p; var->red   .length= *++p;
> > > +   var->green .offset= *++p; var->green .length= *++p;
> > > +   var->blue  .offset= *++p; var->blue  .length= *++p;
> > > +   var->transp.offset= *++p; var->transp.length= *++p;
> > 
> > Please no. Access fields by their names, and do not assume anything
> > about padding.
> >                                                 Petr Vandrovec
> >                                                 vandrove@vc.cvut.cz
> >                                                 
> 
> I'm sorry, Petr, why don't you answer anything to me?  I'd sent the
> cured patch a week ago...

What I should answer? Linus is not here, AFAIK, so patch sits on my
harddrive.
					Petr Vandrovec
					vandrove@vc.cvut.cz