From: Sebastian Droege <sebastian.droege@gmx.de>
To: Dave Jones <davej@suse.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Linux 2.5.7-dj3 - BUG & PATCH
Date: Thu, 4 Apr 2002 17:22:38 +0200 [thread overview]
Message-ID: <20020404172238.62bf1d41.sebastian.droege@gmx.de> (raw)
In-Reply-To: <20020404054923.A28437@suse.de>
[-- Attachment #1: Type: text/plain, Size: 3150 bytes --]
Hi,
I have a problem in 2.5.7-dj3 which doesn't exist in 2.5.8-pre1...
My USB keyboard and mouse are detected properly but aren't usable
I get the same behaviour when unsetting CONFIG_USB_HIDINPUT in 2.5.8-pre1
grepping for CONFIG_USB_HIDINPUT in 2.5.7-dj3 finds something but the option doesn't show in old/menuconfig
When setting CONFIG_USB_HIDINPUT=y by hand in 2.5.7-dj3 I get a compile error:
make[3]: Entering directory `/usr/src/linux-2.5.7/drivers/usb'
gcc -D__KERNEL__ -I/usr/src/linux-2.5.7/include -Wall -Wstrict-prototypes -Wno-trigraphs -O6 -fomit-frame-pointer -fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2 -march=i686 -DKBUILD_BASENAME=hid_input -c -o hid-input.o hid-input.c
hid-input.c:335: redefinition of `hidinput_hid_event'
hid.h:411: `hidinput_hid_event' previously defined here
hid-input.c:413: redefinition of `hidinput_connect'
hid.h:412: `hidinput_connect' previously defined here
hid-input.c:458: redefinition of `hidinput_disconnect'
hid.h:413: `hidinput_disconnect' previously defined here
make[3]: *** [hid-input.o] Fehler 1
I don't see any differences between 2.5.7-dj3 and 2.5.8-pre1 which can cause such error but the patch at the bottom solves it ;)
Maybe someone can explain me why 2.5.8-pre1 compiles without the #ifdefs (with CONFIG_USB_HIDINPUT set and unset) and not in 2.5.7-dj3
With this patch my mouse and keyboard work again
Bye
diff -Nur linux-2.5.7/drivers/usb/Config.in linux-2.5.7-2/drivers/usb/Config.in
--- linux-2.5.7/drivers/usb/Config.in Thu Apr 4 17:17:57 2002
+++ linux-2.5.7-2/drivers/usb/Config.in Thu Apr 4 17:15:38 2002
@@ -53,6 +53,7 @@
comment ' Input core support is needed for USB HID'
else
dep_tristate ' USB Human Interface Device (full HID) support' CONFIG_USB_HID $CONFIG_USB $CONFIG_INPUT
+ dep_mbool ' HID input layer support' CONFIG_USB_HIDINPUT $CONFIG_INPUT $CONFIG_USB_HID
dep_mbool ' /dev/hiddev raw HID device support (EXPERIMENTAL)' CONFIG_USB_HIDDEV $CONFIG_USB_HID
if [ "$CONFIG_USB_HID" != "y" ]; then
dep_tristate ' USB HIDBP Keyboard (basic) support' CONFIG_USB_KBD $CONFIG_USB $CONFIG_INPUT
diff -Nur linux-2.5.7/drivers/usb/hid-input.c linux-2.5.7-2/drivers/usb/hid-input.c
--- linux-2.5.7/drivers/usb/hid-input.c Mon Mar 18 21:37:13 2002
+++ linux-2.5.7-2/drivers/usb/hid-input.c Thu Apr 4 17:20:55 2002
@@ -331,6 +331,7 @@
}
}
+#ifdef CONFIG_USB_HIDINPUT
void hidinput_hid_event(struct hid_device *hid, struct hid_field *field, struct hid_usage *usage, __s32 value)
{
struct input_dev *input = &hid->input;
@@ -373,6 +374,7 @@
if ((field->flags & HID_MAIN_ITEM_RELATIVE) && (usage->type == EV_KEY))
input_event(input, usage->type, usage->code, 0);
}
+#endif
static int hidinput_input_event(struct input_dev *dev, unsigned int type, unsigned int code, int value)
{
@@ -403,6 +405,7 @@
hid_close(hid);
}
+#ifdef CONFIG_USB_HIDINPUT
/*
* Register the input device; print a message.
* Configure the input layer interface
@@ -458,3 +461,4 @@
{
input_unregister_device(&hid->input);
}
+#endif
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2002-04-04 15:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-04-04 5:49 Linux 2.5.7-dj3 Dave Jones
2002-04-04 7:50 ` Adrian Bunk
2002-04-04 12:16 ` Dave Jones
2002-04-04 12:37 ` Dave Jones
2002-04-04 11:41 ` Martin Dalecki
2002-04-04 15:22 ` Sebastian Droege [this message]
2002-04-04 17:54 ` Linux 2.5.7-dj3 - BUG & PATCH Greg KH
2002-04-04 18:01 ` Dave Jones
2002-04-05 6:45 ` Greg KH
2002-04-05 9:48 ` Sebastian Droege
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020404172238.62bf1d41.sebastian.droege@gmx.de \
--to=sebastian.droege@gmx.de \
--cc=davej@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®