From: Itai Nahshon <nahshon@actcom.co.il>
To: "Anthony J. Breeds-Taurima" <tony@cantech.net.au>,
Marcelo Tosatti <marcelo@conectiva.com.br>,
Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Change "return EBLAH" to "return -EBLAH in drivers/*
Date: Wed, 17 Apr 2002 15:29:35 +0300 [thread overview]
Message-ID: <200204171529.35613.nahshon@actcom.co.il> (raw)
In-Reply-To: <Pine.LNX.4.33.0204171223370.14274-100000@thor.cantech.net.au>
On Wednesday 17 April 2002 07:42 am, Anthony J. Breeds-Taurima wrote:
> --- linux-2.4.19-pre6.clean/drivers/net/plip.c Mon Oct 22 16:05:31 2001
> +++ linux-2.4.19-pre6/drivers/net/plip.c Wed Apr 17 11:08:35 2002
...
> - return ERROR;
> + return -ERROR;
At least the changes to plip.c are wrong.
ERROR is not an errno value:
#define ERROR 2
and the return from this function is propgated to a test
if (error != ERROR) { /* Timeout */
Which will go wrong with the suggested patch.
-- Itai
next prev parent reply other threads:[~2002-04-17 12:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-04-17 4:42 Anthony J. Breeds-Taurima
2002-04-17 12:29 ` Itai Nahshon [this message]
2002-04-17 16:12 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200204171529.35613.nahshon@actcom.co.il \
--to=nahshon@actcom.co.il \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
--cc=tony@cantech.net.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®