From: Mikael Pettersson <mikpe@csd.uu.se>
To: marcelo@conectiva.com.br
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] fix 2.4.19-pre8 UP APIC breakage
Date: Sat, 4 May 2002 16:04:58 +0200 (MET DST) [thread overview]
Message-ID: <200205041404.QAA02175@harpo.it.uu.se> (raw)
Marcelo,
2.4.19-pre8 gets a linker error if CONFIG_X86_UP_APIC=y and
CONFIG_X86_UP_IOAPIC=n:
init/main.o: In function `smp_init':
init/main.o(.text.init+0x59e): undefined reference to `skip_ioapic_setup'
arch/i386/kernel/kernel.o: In function `broken_pirq':
arch/i386/kernel/kernel.o(.text.init+0x3272): undefined reference to `skip_ioapic_setup'
The patch below fixes this. Please apply.
/Mikael
--- linux-2.4.19-pre8/arch/i386/kernel/dmi_scan.c.~1~ Sat May 4 14:45:18 2002
+++ linux-2.4.19-pre8/arch/i386/kernel/dmi_scan.c Sat May 4 15:33:26 2002
@@ -418,7 +418,7 @@
printk(KERN_INFO " *** If you see IRQ problems, in paticular SCSI resets and hangs at boot\n");
printk(KERN_INFO " *** contact your hardware vendor and ask about updates.\n");
printk(KERN_INFO " *** Building an SMP kernel may evade the bug some of the time.\n");
-#ifdef CONFIG_X86_UP_APIC
+#ifdef CONFIG_X86_IO_APIC
skip_ioapic_setup = 0;
#endif
return 0;
--- linux-2.4.19-pre8/init/main.c.~1~ Sat May 4 15:25:27 2002
+++ linux-2.4.19-pre8/init/main.c Sat May 4 15:33:32 2002
@@ -293,11 +293,9 @@
#ifndef CONFIG_SMP
#ifdef CONFIG_X86_LOCAL_APIC
-extern int skip_ioapic_setup;
static void __init smp_init(void)
{
- if (!skip_ioapic_setup)
- APIC_init_uniprocessor();
+ APIC_init_uniprocessor();
}
#else
#define smp_init() do { } while (0)
reply other threads:[~2002-05-04 14:05 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200205041404.QAA02175@harpo.it.uu.se \
--to=mikpe@csd.uu.se \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®