mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@redhat.com>
To: zippel@linux-m68k.org
Cc: thunder@ngforever.de, linux-kernel@vger.kernel.org
Subject: Re: pfn-Functionset out of order for sparc64 in current Bk tree?
Date: Tue, 07 May 2002 14:08:48 -0700 (PDT)	[thread overview]
Message-ID: <20020507.140848.29493830.davem@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.21.0205072115360.32715-100000@serv>

   From: Roman Zippel <zippel@linux-m68k.org>
   Date: Tue, 7 May 2002 21:22:13 +0200 (CEST)

   On Tue, 7 May 2002, Thunder from the hill wrote:
   
   >  - pte_pfn(x) is declared as
   >    ((unsigned long)(((x).pte_low >> PAGE_SHIFT)))
   >    in 2-level pgtable,
   >    (((x).pte_low >> PAGE_SHIFT) | ((x).pte_high << (32 - PAGE_SHIFT)))
   >    in 3-level. I suppose 2-level shouldn't exactly match here, how far 
   >    must the 3-level version be changed in order to fit sparc64? A lot?
   
   #define pte_pfn(x) (pte_val(x) >> PAGE_SHIFT)
   
   >  - pfn_valid(pfn) is described as ((pfn) < max_mapnr). Suppose this is OK 
   >    on Sparc64 either?
   
   Yes.
   
   >  - pfn_pte(page,prot) is defined as
   >    __pte(((pfn) << PAGE_SHIFT) | pgprot_val(prot))
   >    How far does this go for Sparc64?
   
   #define pfn_pte(pfn,prot) mk_pte_phys(pfn << PAGE_SHIFT, prot)
   but you should better replace mk_pte_phys completely.

All of this is ignoring the fact that phys_base has to be subtracted
from any physical address before applying as an index to mem_map on
sparc64.

I have the correct fixes for sparc64 in my tree and I'll merge it
all to Linus.

  parent reply	other threads:[~2002-05-07 21:20 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-05-07 19:04 Thunder from the hill
2002-05-07 19:22 ` Roman Zippel
2002-05-07 20:43   ` Thunder from the hill
2002-05-07 21:12     ` David S. Miller
2002-05-07 21:08   ` David S. Miller [this message]
2002-05-07 21:52     ` Thunder from the hill
2002-05-07 21:44       ` David S. Miller
2002-05-07 23:11     ` Roman Zippel
2002-05-07 19:12 Holzrichter, Bruce
2002-05-07 19:27 ` Jan-Benedict Glaw
2002-05-07 23:08   ` Roman Zippel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020507.140848.29493830.davem@redhat.com \
    --to=davem@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=thunder@ngforever.de \
    --cc=zippel@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®