From: Andreas Dilger <adilger@clusterfs.com>
To: Thunder from the hill <thunder@ngforever.de>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Possible SCSI (sr) mini-cleanup
Date: Tue, 7 May 2002 16:02:35 -0600 [thread overview]
Message-ID: <20020507220235.GB27824@turbolinux.com> (raw)
In-Reply-To: <Pine.LNX.4.44.0205071445480.4189-100000@hawkeye.luckynet.adm>
On May 07, 2002 14:50 -0600, Thunder from the hill wrote:
> I don't see where the variable and the label have been used. Are they
> useful for anything? If they are, tell me please!
> @@ -723,8 +721,6 @@
> goto cleanup_cds;
> memset(sr_sizes, 0, sr_template.dev_max * sizeof(int));
> return 0;
> -cleanup_sizes:
> - kfree(sr_sizes);
> cleanup_cds:
> kfree(scsi_CDs);
> cleanup_devfs:
Note that you are also removing the "kfree(sr_sizes)" which is
definitely used...
Cheers, Andreas
--
Andreas Dilger
http://www-mddsp.enel.ucalgary.ca/People/adilger/
http://sourceforge.net/projects/ext2resize/
next prev parent reply other threads:[~2002-05-07 22:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-05-07 20:50 Thunder from the hill
2002-05-07 22:02 ` Andreas Dilger [this message]
2002-05-07 22:12 ` David Weinehall
2002-05-07 22:39 ` Thunder from the hill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020507220235.GB27824@turbolinux.com \
--to=adilger@clusterfs.com \
--cc=linux-kernel@vger.kernel.org \
--cc=thunder@ngforever.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®