mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tomas Szepe <szepe@pinerecords.com>
To: Keith Owens <kaos@ocs.com.au>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [patch] 2.4.19-pre8-ac2 kbuild 2.4 tmp_include_depends
Date: Sun, 12 May 2002 14:54:39 +0200	[thread overview]
Message-ID: <20020512125439.GE3749@louise.pinerecords.com> (raw)
In-Reply-To: <20020512103946.GB3749@louise.pinerecords.com> <22944.1021206179@ocs3.intra.ocs.com.au>

> [Keith Owens <kaos@ocs.com.au>, May-12 2002, Sun, 22:22 +1000]
> On Sun, 12 May 2002 12:39:46 +0200, 
> Tomas Szepe <szepe@pinerecords.com> wrote:
> >> [Keith Owens <kaos@ocs.com.au>, May-12 2002, Sun, 20:11 +1000]
> >> Missed one occurrence of .tmp_include_depends.  Edit Makefile, find
> >> $(patsubst %, _dir_%, $(SUBDIRS)) and change .tmp_include_depends to
> >> tmp_include_depends (no '.' at start).
> >> 
> >> Corrected patch against 2.4.19-pre8-ac2.
> >
> >Great work, Keith!
> >"make modules_install" takes like 2 seconds w/ -ac now!
> 
> That was not the aim (although I will accept the praise :).  The patch
> ensures that cross directory header dependencies are done correctly on
> kbuild 2.4.  Any speed up as a side effect of removing .hdepend from
> Rules.make is a bonus.

Now these are some side effects I like!

<cut>
2.4.19-pre8-ac1:
$ time make dep clean bzImage modules
...
real    6m22.176s

$ time su -c 'make modules_install'
...
real    0m6.963s

----

2.4.19-pre8-ac2 + patch-2.4.19-pre8-ac2-kbuildfix2:
$ time make dep clean bzImage modules
...
real    5m57.509s

$ time su -c 'make modules_install'
...
real    0m2.255s
<cut>

> kbuild mantra - correctness first, speed second.

Thumbs up!


T.

  reply	other threads:[~2002-05-12 12:55 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-05-12  2:11 Keith Owens
2002-05-12  9:04 ` Axel H. Siebenwirth
2002-05-12 10:11   ` Keith Owens
2002-05-12 10:39     ` Tomas Szepe
2002-05-12 12:22       ` Keith Owens
2002-05-12 12:54         ` Tomas Szepe [this message]
2002-05-13  2:10 ` khromy
2002-05-13  2:13   ` Keith Owens
2002-05-12 11:31 Hugh
2002-05-12 11:50 ` Keith Owens

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020512125439.GE3749@louise.pinerecords.com \
    --to=szepe@pinerecords.com \
    --cc=kaos@ocs.com.au \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®