mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Richard Gooch <rgooch@ras.ucalgary.ca>
To: Alexander Viro <viro@math.psu.edu>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] devfs v212 available
Date: Sun, 12 May 2002 20:36:25 -0600	[thread overview]
Message-ID: <200205130236.g4D2aPX13250@vindaloo.ras.ucalgary.ca> (raw)
In-Reply-To: <Pine.GSO.4.21.0205110213300.20383-100000@weyl.math.psu.edu>

Alexander Viro writes:
> On Sat, 11 May 2002, Richard Gooch wrote:
> > This is against 2.5.14. Highlights of this release:
> > 
> > - Added BKL to <devfs_open> because drivers still need it
> 
> Sigh...  Look at the callers of check_disc_changed() and check
> what's going on with traversing directory contents there.

OK, I've had a look. There is indeed a race there. While it is safe
against module unloading, it isn't safe against removal of entries
from the directory. I'm considering some different options to fix this
(one is simple and obvious, the other will be a little more
efficient).

Question: can invalidate_device() and the bdops methods
check_media_change() and revalidate() be called with a lock held?

				Regards,

					Richard....
Permanent: rgooch@atnf.csiro.au
Current:   rgooch@ras.ucalgary.ca

  reply	other threads:[~2002-05-13  2:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-05-11  6:08 Richard Gooch
2002-05-11  6:17 ` Alexander Viro
2002-05-13  2:36   ` Richard Gooch [this message]
2002-05-13  4:10     ` Alexander Viro
2002-05-13  4:28       ` Richard Gooch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200205130236.g4D2aPX13250@vindaloo.ras.ucalgary.ca \
    --to=rgooch@ras.ucalgary.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@math.psu.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®