From: Adam Kropelin <akropel1@rochester.rr.com>
To: Keith Owens <kaos@ocs.com.au>
Cc: davej@suse.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 2.5.1[345]-dj Add cpqarray_init() back into genhd.c
Date: Mon, 13 May 2002 22:49:08 -0400 [thread overview]
Message-ID: <20020514024908.GA7695@www.kroptech.com> (raw)
In-Reply-To: <20020514020334.GA24417@www.kroptech.com> <6422.1021343063@kao2.melbourne.sgi.com>
On Tue, May 14, 2002 at 12:24:23PM +1000, Keith Owens wrote:
> On Mon, 13 May 2002 22:03:34 -0400,
> Adam Kropelin <akropel1@rochester.rr.com> wrote:
> >In 2.5.13-dj1, the call to cpqarray_init() in drivers/block/genhd.c was
> >dropped. I'm not sure what the intent was since the driver seems to work fine
<snip>
> The real problem appears to be cpqarray.c, it wraps the init/exit code
> in #ifdef MODULE, so the init code is only available to modules. I
> think that cpqarray.c should remove the #ifdef MODULE and use the same
> init mechanism as other drivers, including module_init/exit. I don't
> have a card and the code is a mess so I am not going to attempt a patch.
I'm not seeing it. I see init_module() and cleanup_module() wrapped as you say
but cpqarray_init() is outside the #ifdef. Also, two versions of cpqarray_setup
are provided based on #ifdef MODULE but this doesn't look problematic to me.
I'm a newbie, for sure. Am I overlooking something obvious?
--Adam
next prev parent reply other threads:[~2002-05-14 2:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-05-14 2:03 Adam Kropelin
2002-05-14 2:24 ` Keith Owens
2002-05-14 2:49 ` Adam Kropelin [this message]
2002-05-14 3:31 ` Keith Owens
2002-05-14 11:38 ` Adam Kropelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020514024908.GA7695@www.kroptech.com \
--to=akropel1@rochester.rr.com \
--cc=davej@suse.de \
--cc=kaos@ocs.com.au \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®