From: Stephen Rothwell <sfr@canb.auug.org.au>
To: linux-kernel@vger.kernel.org
Cc: rmk@arm.linux.org.uk, bjornw@axis.com, davidm@hpl.hp.com,
paulus@au.ibm.com, engebret@us.ibm.com, jes@trained-monkey.org,
ralf@gnu.org, schwidefsky@de.ibm.com, davem@redhat.com,
gniibe@m17n.org, ak@suse.de
Subject: [PATCH] Signal cleanups part1: siginfo rationalisation
Date: Tue, 14 May 2002 16:00:43 +1000 [thread overview]
Message-ID: <20020514160043.05fbd4f1.sfr@canb.auug.org.au> (raw)
http://www.canb.auug.org.au/15-si.1.1.diff.gz
[Please do not flame me too much, just be happy that I did not post
the whole 120K patch :-)]
This patch creates asm-generic/siginfo.h and uses it to remove a
lot of duplicate code in the various asm-*/siginfo.h files. Some
if it is a little ugly, but I think it will be worth it just to
help us eliminate some of the bugs that have come from code copying.
diffstat looks like this:
asm-alpha/siginfo.h | 212 -----------------------------------------
asm-arm/siginfo.h | 230 ---------------------------------------------
asm-cris/siginfo.h | 229 ---------------------------------------------
asm-generic/siginfo.h | 254 ++++++++++++++++++++++++++++++++++++++++++++++++++
asm-i386/siginfo.h | 230 ---------------------------------------------
asm-ia64/siginfo.h | 145 ++--------------------------
asm-m68k/siginfo.h | 176 ----------------------------------
asm-mips/siginfo.h | 156 ++----------------------------
asm-mips64/siginfo.h | 155 ++----------------------------
asm-parisc/siginfo.h | 225 --------------------------------------------
asm-ppc/siginfo.h | 227 --------------------------------------------
asm-ppc64/siginfo.h | 228 --------------------------------------------
asm-s390/siginfo.h | 156 ------------------------------
asm-s390x/siginfo.h | 156 ------------------------------
asm-sh/siginfo.h | 229 ---------------------------------------------
asm-sparc/siginfo.h | 164 --------------------------------
asm-sparc64/siginfo.h | 172 +--------------------------------
asm-x86_64/siginfo.h | 229 ---------------------------------------------
18 files changed, 326 insertions(+), 3247 deletions(-)
so you can see there was LOTS of duplication :-)
Let me know if it is too ugly, otherwise, please apply. This builds
on i386 and ppc64 and shouldn't (in theory) change the object code
produced (modulo some static/extern inlines).
I intent to follow this with more code consolidation and some bug fixes
to the siginfo handling code.
This is CC'd to all the architecture maintainers in the hope that they
will check that I have not broken them badly.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
next reply other threads:[~2002-05-14 6:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-05-14 6:00 Stephen Rothwell [this message]
2002-05-14 6:06 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020514160043.05fbd4f1.sfr@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=ak@suse.de \
--cc=bjornw@axis.com \
--cc=davem@redhat.com \
--cc=davidm@hpl.hp.com \
--cc=engebret@us.ibm.com \
--cc=gniibe@m17n.org \
--cc=jes@trained-monkey.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@au.ibm.com \
--cc=ralf@gnu.org \
--cc=rmk@arm.linux.org.uk \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®