From: Mark Gross <mgross@unix-os.sc.intel.com>
To: Robert Love <rml@tech9.net>, Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Daniel Jacobowitz <dan@debian.org>, Andi Kleen <ak@suse.de>,
linux-kernel@vger.kernel.org
Subject: Re: PATCH Multithreaded core dump support for the 2.5.14 (and 15) kernel.
Date: Thu, 16 May 2002 14:40:24 -0400 [thread overview]
Message-ID: <200205162140.g4GLelw01400@unix-os.sc.intel.com> (raw)
In-Reply-To: <E178SrT-00057L-00@the-village.bc.nu> <1021584279.914.4.camel@sinai>
On Thursday 16 May 2002 05:24 pm, Robert Love wrote:
> On Thu, 2002-05-16 at 14:32, Alan Cox wrote:
> > > For this to happen that semaphore would have to held across
> > > schedule()'s. The ONLY place I've seen that in the kernel is
> > > set_CPUs_allowed + migration_thread.
> >
> > The 2.5 kernel is pre-emptible.
>
> Indeed :)
>
> But there is plenty of places in the kernel - sans preemption - where we
> sleep while holding a semaphore. Was that the original question? If
> so, set_cpus_allowed by be one of the few _explicit_ places but we
> implicitly sleep holding a semaphore all over. Heck, we use them for
> user-space synchronization.
>
> Robert Love
>
The original question was:
Couldn't the TCore patch deadlock in elf_core_dump on a semiphore held by a
sleeping process that gets placed onto the phantom runque?
So far I can't tell the problem is real or not, but I'm worried :(
I haven't hit any such deadlocks in my stress testing, such as it is. In my
review of the code I don't see any obviouse problems dispite the fact that
the mmap_sem is explicitly grabbed by elf_core_dump.
--mgross
next prev parent reply other threads:[~2002-05-16 21:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <59885C5E3098D511AD690002A5072D3C057B485B@orsmsx111.jf.intel.com.suse.lists.linux.kernel>
[not found] ` <20020515120722.A17644@in.ibm.com.suse.lists.linux.kernel>
[not found] ` <20020515140448.C37@toy.ucw.cz.suse.lists.linux.kernel>
[not found] ` <200205152353.g4FNrew30146@unix-os.sc.intel.com.suse.lists.linux.kernel>
2002-05-16 12:54 ` Andi Kleen
2002-05-16 14:13 ` Mark Gross
2002-05-16 17:27 ` Andi Kleen
2002-05-16 17:36 ` Daniel Jacobowitz
2002-05-16 18:08 ` Mark Gross
2002-05-16 21:32 ` Alan Cox
2002-05-16 21:24 ` Robert Love
2002-05-16 18:40 ` Mark Gross [this message]
2002-05-20 15:44 Gross, Mark
-- strict thread matches above, loose matches on Subject: below --
2002-05-17 12:26 Erich Focht
2002-05-14 16:38 Gross, Mark
2002-05-15 6:37 ` Vamsi Krishna S .
2002-05-15 14:04 ` Pavel Machek
2002-05-15 20:53 ` Mark Gross
2002-05-16 10:11 ` Pavel Machek
2002-05-13 19:17 Mark Gross
2002-05-14 15:35 ` Erich Focht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200205162140.g4GLelw01400@unix-os.sc.intel.com \
--to=mgross@unix-os.sc.intel.com \
--cc=ak@suse.de \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=dan@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rml@tech9.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®