From: Andreas Dilger <adilger@clusterfs.com>
To: Andrew Morton <akpm@zip.com.au>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: Re: [patch 6/15] larger b_size, and misc fixlets
Date: Sun, 19 May 2002 16:15:32 -0600 [thread overview]
Message-ID: <20020519221532.GE26598@turbolinux.com> (raw)
In-Reply-To: <3CE7FF89.16AF9B93@zip.com.au>
On May 19, 2002 12:39 -0700, Andrew Morton wrote:
> - make the printk in buffer_io_error() sector_t-aware.
> =====================================
> --- 2.5.16/fs/buffer.c~sector_t-printing Sun May 19 11:49:47 2002
> +++ 2.5.16-akpm/fs/buffer.c Sun May 19 12:02:57 2002
> @@ -179,8 +179,8 @@ __clear_page_buffers(struct page *page)
>
> static void buffer_io_error(struct buffer_head *bh)
> {
> - printk(KERN_ERR "Buffer I/O error on device %s, logical block %ld\n",
> - bdevname(bh->b_bdev), bh->b_blocknr);
> + printk(KERN_ERR "Buffer I/O error on device %s, logical block %Ld\n",
> + bdevname(bh->b_bdev), (u64)bh->b_blocknr);
> }
Not that I'm a 64-bit system user/developer, but it is my understanding
that u64 == long on a 64-bit platform, so your cast to u64 does not
actually change the type of b_blocknr as far as printk is concerned.
You would need to cast it to unsigned long long instead.
Cheers, Andreas
--
Andreas Dilger
http://www-mddsp.enel.ucalgary.ca/People/adilger/
http://sourceforge.net/projects/ext2resize/
next prev parent reply other threads:[~2002-05-19 22:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-05-19 19:39 Andrew Morton
2002-05-19 22:15 ` Andreas Dilger [this message]
2002-05-19 22:53 ` Andrew Morton
2002-05-19 22:59 ` Anton Altaparmakov
[not found] <368842013@toto.iv>
2002-05-20 2:09 ` Peter Chubb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020519221532.GE26598@turbolinux.com \
--to=adilger@clusterfs.com \
--cc=akpm@zip.com.au \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®