From: Christoph Hellwig <hch@infradead.org>
To: Mikael Pettersson <mikpe@csd.uu.se>
Cc: viro@math.psu.edu, linux-kernel@vger.kernel.org
Subject: Re: [RFC] possible fix for broken floppy driver since 2.5.13
Date: Tue, 21 May 2002 13:24:51 +0100 [thread overview]
Message-ID: <20020521132451.A13419@infradead.org> (raw)
In-Reply-To: <200205201701.TAA04143@harpo.it.uu.se>
On Mon, May 20, 2002 at 07:01:52PM +0200, Mikael Pettersson wrote:
> Since 2.5.13 I've been unable to use drivers/block/floppy.c.
> There were two symptoms: /dev/fd0 was read-only until after
> the first read, and writes wrote currupt data to the media.
>
> The patch below against 2.5.16 fixes these problems for me:
>
> - The read-only problem was caused by a getblk() call in
> floppy_revalidate() which had been commented out (2.5.13
> did away with getblk() altogether.) This call is necessary,
> so the patch reintroduces a private getblk() in floppy.c.
Please don't use getblk(), but go directly through the bio interface.
In 2.5 the buffer_heads are just a legacy interface for filesystems and
are not supposed to be used by lowlevel drivers.
next prev parent reply other threads:[~2002-05-21 12:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-05-20 17:01 Mikael Pettersson
2002-05-21 12:24 ` Christoph Hellwig [this message]
2002-05-21 12:35 ` Mikael Pettersson
2002-05-21 12:51 ` Christoph Hellwig
2002-05-26 14:19 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020521132451.A13419@infradead.org \
--to=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikpe@csd.uu.se \
--cc=viro@math.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®