From: Pavel Machek <pavel@ucw.cz>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: kernel list <linux-kernel@vger.kernel.org>,
ACPI mailing list <acpi-devel@lists.sourceforge.net>
Subject: Re: suspend-to-{RAM,disk} for 2.5.17
Date: Wed, 22 May 2002 01:27:33 +0200 [thread overview]
Message-ID: <20020521232732.GA16320@elf.ucw.cz> (raw)
In-Reply-To: <Pine.LNX.4.33.0205211557410.1307-100000@penguin.transmeta.com> <Pine.LNX.4.33.0205211614200.15094-100000@penguin.transmeta.com>
Hi!
> > Applied. Nothing needed but some time for me to look through it.
>
> Well, I may have to revert that.
Sorry about that. Safety check that should not be needed.
> mm/mm.o: In function `rw_swap_page':
> mm/mm.o(.text+0xaeb2): undefined reference to `suspend_device'
>
> Please send me a fix asap.
This fixes it. I also broke compilation in ACPI but not SWSUSP case
(but it ate disks before, so ... :-).
Pavel
--- linux-swsusp.linus/mm/page_io.c Tue May 21 23:33:38 2002
+++ linux-swsusp/mm/page_io.c Wed May 22 01:20:04 2002
@@ -86,15 +86,11 @@
* - it's marked as being swap-cache
* - it's associated with the swap inode
*/
-extern long suspend_device;
void rw_swap_page(int rw, struct page *page)
{
swp_entry_t entry;
entry.val = page->index;
-
- if (suspend_device)
- panic("I refuse to corrupt memory/swap.");
if (!PageLocked(page))
PAGE_BUG(page);
--
(about SSSCA) "I don't say this lightly. However, I really think that the U.S.
no longer is classifiable as a democracy, but rather as a plutocracy." --hpa
next prev parent reply other threads:[~2002-05-21 23:28 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-05-21 22:28 Pavel Machek
2002-05-21 23:01 ` Linus Torvalds
2002-05-21 23:15 ` Linus Torvalds
2002-05-21 23:27 ` Pavel Machek [this message]
2002-05-21 23:40 ` Pavel Machek
2002-05-21 23:20 ` Pavel Machek
2002-05-21 23:26 ` Linus Torvalds
2002-05-21 23:33 ` Pavel Machek
2002-05-22 0:09 ` Linus Torvalds
2002-05-22 0:15 ` Pavel Machek
2002-05-22 6:49 ` Martin Dalecki
2002-05-22 9:00 ` Pavel Machek
2002-05-22 10:03 ` Xavier Bestel
2002-05-22 9:03 ` Martin Dalecki
2002-05-22 10:35 ` Albert D. Cahalan
2002-05-22 10:42 ` Xavier Bestel
2002-05-22 12:54 ` Frank v Waveren
2002-05-22 15:59 ` Linus Torvalds
2002-05-25 13:30 ` Geert Uytterhoeven
2002-05-26 17:20 ` Pavel Machek
2002-05-27 19:40 ` William Lee Irwin III
2002-05-28 19:20 ` Pavel Machek
2002-05-28 19:32 ` Pavel Machek
2002-05-28 21:09 ` William Lee Irwin III
2002-05-28 21:11 ` Pavel Machek
2002-05-28 21:24 ` William Lee Irwin III
2002-05-28 21:34 ` Pavel Machek
2002-05-28 21:53 ` William Lee Irwin III
2002-05-28 22:00 ` Pavel Machek
2002-05-28 22:28 ` William Lee Irwin III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020521232732.GA16320@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=acpi-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®