From: Andrey Panin <pazke@orbita1.ru>
To: Martin Dalecki <dalecki@evision-ventures.com>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] Serverworks IDE driver: missing static
Date: Wed, 22 May 2002 13:10:58 +0400 [thread overview]
Message-ID: <20020522091058.GA312@pazke.ipt> (raw)
[-- Attachment #1.1: Type: text/plain, Size: 336 bytes --]
Hi,
svwks_tune_chipset() function contains 3 arrays which IMHO should be static.
Attached patch fixed it, saving for me 48 bytes of code :))
Compiles, but untested. Please consider applying.
Best regards.
--
Andrey Panin | Embedded systems software engineer
pazke@orbita1.ru | PGP key: wwwkeys.eu.pgp.net
[-- Attachment #1.2: patch-serverworks --]
[-- Type: text/plain, Size: 772 bytes --]
diff -urN -X /usr/share/dontdiff linux.vanilla/drivers/ide/serverworks.c linux/drivers/ide/serverworks.c
--- linux.vanilla/drivers/ide/serverworks.c Tue May 21 01:55:59 2002
+++ linux/drivers/ide/serverworks.c Wed May 22 03:36:04 2002
@@ -242,9 +242,9 @@
static int svwks_tune_chipset(struct ata_device *drive, byte speed)
{
- byte udma_modes[] = { 0x00, 0x01, 0x02, 0x03, 0x04, 0x05 };
- byte dma_modes[] = { 0x77, 0x21, 0x20 };
- byte pio_modes[] = { 0x5d, 0x47, 0x34, 0x22, 0x20 };
+ static byte udma_modes[] = { 0x00, 0x01, 0x02, 0x03, 0x04, 0x05 };
+ static byte dma_modes[] = { 0x77, 0x21, 0x20 };
+ static byte pio_modes[] = { 0x5d, 0x47, 0x34, 0x22, 0x20 };
struct ata_channel *hwif = drive->channel;
struct pci_dev *dev = hwif->pci_dev;
[-- Attachment #2: Type: application/pgp-signature, Size: 232 bytes --]
next reply other threads:[~2002-05-22 9:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-05-22 9:10 Andrey Panin [this message]
2002-05-22 8:06 ` Martin Dalecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020522091058.GA312@pazke.ipt \
--to=pazke@orbita1.ru \
--cc=dalecki@evision-ventures.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®