From: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: linux-kernel@vger.kernel.org
Subject: [patch] 2.5.18 pci/setup-bus.c: incorrect BUG() calls
Date: Mon, 27 May 2002 20:51:54 +0400 [thread overview]
Message-ID: <20020527205154.A1338@jurassic.park.msu.ru> (raw)
Previously assigned resources are perfectly valid - just silently
ignore them.
Ivan.
--- 2.5.18/drivers/pci/setup-bus.c Sat May 25 05:55:25 2002
+++ linux/drivers/pci/setup-bus.c Mon May 27 16:06:39 2002
@@ -228,10 +228,8 @@ pbus_size_io(struct pci_bus *bus)
struct resource *r = &dev->resource[i];
unsigned long r_size;
- if (!(r->flags & IORESOURCE_IO))
+ if (r->parent || !(r->flags & IORESOURCE_IO))
continue;
- if (r->parent)
- BUG();
r_size = r->end - r->start + 1;
if (r_size < 0x400)
@@ -283,10 +281,8 @@ pbus_size_mem(struct pci_bus *bus, unsig
struct resource *r = &dev->resource[i];
unsigned long r_size;
- if ((r->flags & mask) != type)
+ if (r->parent || (r->flags & mask) != type)
continue;
- if (r->parent)
- BUG();
r_size = r->end - r->start + 1;
/* For bridges size != alignment */
align = (i < PCI_BRIDGE_RESOURCES) ? r_size : r->start;
reply other threads:[~2002-05-27 16:52 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020527205154.A1338@jurassic.park.msu.ru \
--to=ink@jurassic.park.msu.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®