From: Pavel Machek <pavel@suse.cz>
To: "Adam J. Richter" <adam@yggdrasil.com>
Cc: linux-kernel@vger.kernel.org, seasons@fornox.hu
Subject: Re: Patch(?): linux-2.5.19 suspend.c compilation fixes, one iffy change
Date: Thu, 30 May 2002 21:59:16 +0200 [thread overview]
Message-ID: <20020530195914.GA1849@elf.ucw.cz> (raw)
In-Reply-To: <200205300318.UAA00301@baldur.yggdrasil.com>
Hi!
> kernel/suspend.c no longer compiles in linux-2.5.19, due to
> the elimination of tq_disk. I infer from the comments on the
> new routine blk_run_queues() and from similar changes elsewhere in
> 2.5.19 that I should probably replace run_task_queue(&tq_disk) with
> blk_run_queues(). I also had to elimiante your sanity check which
> referenced tq_disk. I will cc this to linux-kernel in case anyone
> else knows the answer and to prevent duplication of effort.
>
> The rest of the changes just address compiler warnings,
> but you might want to look at them anyhow, especially my changing
> the types of suspend_pagedir and pagedir_save from unsigned long
> to suspend_pagedir_t*.
>
> Please let me know if you see a problem with this patch, and
> if you are going to shepherd it to Linus or if you me to submit it
> directly or process it some other way.
Patch is nice, thanx a lot. I'll submit it to Linus.
Pavel
--
(about SSSCA) "I don't say this lightly. However, I really think that the U.S.
no longer is classifiable as a democracy, but rather as a plutocracy." --hpa
next prev parent reply other threads:[~2002-05-30 21:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-05-30 3:18 Adam J. Richter
2002-05-30 19:59 ` Pavel Machek [this message]
2002-05-30 20:20 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020530195914.GA1849@elf.ucw.cz \
--to=pavel@suse.cz \
--cc=adam@yggdrasil.com \
--cc=linux-kernel@vger.kernel.org \
--cc=seasons@fornox.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®