From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Roman Zippel <zippel@linux-m68k.org>
Cc: linux-kernel@vger.kernel.org, Linus <torvalds@transmeta.com>,
Trivial Kernel Patches <trivial@rustcorp.com.au>
Subject: Re: missing bit from signal patches
Date: Thu, 30 May 2002 22:08:28 +1000 [thread overview]
Message-ID: <20020530220828.3c3192cd.sfr@canb.auug.org.au> (raw)
In-Reply-To: <Pine.LNX.4.21.0205300959050.17583-100000@serv>
Hi Roman,
On Thu, 30 May 2002 10:04:03 +0200 (CEST) Roman Zippel <zippel@linux-m68k.org> wrote:
>
> On Thu, 30 May 2002, Stephen Rothwell wrote:
>
> > The following should allow the affected architectures to build in
> > 2.5.19 as currently there will be two definitions of
> > copy_siginfo_to_user.
>
> There are other build problems. m68k doesn't compile, because siginfo_t is
> defined after the generic include and the inline functions in there access
> that structure. On the other hand I can't put the include after the
> definition, as it depends on other defines in the include.
> I worked around it with some ugly hacks, but a proper fix would be very
> welcome.
Is the following a more ugly hack than yours?
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
diff -ruN 2.5.19-si/include/asm-generic/siginfo.h 2.5.19-si.3/include/asm-generic/siginfo.h
--- 2.5.19-si/include/asm-generic/siginfo.h Thu May 30 09:44:38 2002
+++ 2.5.19-si.3/include/asm-generic/siginfo.h Thu May 30 22:04:54 2002
@@ -64,7 +64,11 @@
} _sifields;
} siginfo_t;
-#endif
+#else /* HAVE_ARCH_SIGINFO_T */
+
+struct siginfo;
+
+#endif /* HAVE_ARCH_SIGINFO_T */
/*
* How these fields are to be accessed.
next prev parent reply other threads:[~2002-05-30 12:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-05-30 0:18 [PATCH] " Stephen Rothwell
2002-05-30 8:04 ` Roman Zippel
2002-05-30 12:08 ` Stephen Rothwell [this message]
2002-05-30 12:46 ` Roman Zippel
2002-05-30 13:26 ` Stephen Rothwell
2002-05-30 14:16 ` Peter Wächtler
2002-05-30 19:57 ` Roman Zippel
2002-05-31 0:24 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020530220828.3c3192cd.sfr@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
--cc=trivial@rustcorp.com.au \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®