From: Pavel Machek <pavel@suse.cz>
To: "Thomas 'Dent' Mirlacher" <dent@cosy.sbg.ac.at>
Cc: Linux-Kernel ML <linux-kernel@vger.kernel.org>
Subject: Re: do_mmap
Date: Mon, 3 Jun 2002 12:19:43 +0000 [thread overview]
Message-ID: <20020603121943.A37@toy.ucw.cz> (raw)
In-Reply-To: <Pine.GSO.4.05.10205311456070.10633-100000@mausmaki.cosy.sbg.ac.at>
Hi!
> what about the do_mmap/do_mmap_pgoff implementation?
> reurn-type: _unsigned_ long (which should be ok cause we've to return
> an adress if len == 0)
> on error: -ERR_*
>
> and the checks in various places are really strange. - well some
> places check for:
> o != NULL
> o > -1024UL
> o ...
>
> guess this nedds some cleanup.
While you are at it... fs/binfmt_elf does mmaps but does not check for errors.
And errors actually do happen there :-(
--
Philips Velo 1: 1"x4"x8", 300gram, 60, 12MB, 40bogomips, linux, mutt,
details at http://atrey.karlin.mff.cuni.cz/~pavel/velo/index.html.
next prev parent reply other threads:[~2002-06-03 19:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-05-31 13:00 do_mmap Thomas 'Dent' Mirlacher
2002-05-31 14:27 ` do_mmap Alan Cox
2002-05-31 13:33 ` do_mmap Thomas 'Dent' Mirlacher
2002-05-31 17:30 ` do_mmap Linus Torvalds
2002-05-31 17:46 ` do_mmap Thomas 'Dent' Mirlacher
2002-05-31 17:56 ` do_mmap Linus Torvalds
2002-05-31 18:10 ` do_mmap Richard B. Johnson
2002-05-31 18:21 ` do_mmap Thomas 'Dent' Mirlacher
2002-05-31 18:38 ` do_mmap Richard B. Johnson
2002-05-31 18:59 ` do_mmap Alan Cox
2002-06-01 11:12 ` do_mmap Kai Henningsen
2002-05-31 19:49 ` do_mmap DervishD
2002-05-31 19:46 ` do_mmap DervishD
2002-06-03 12:19 ` Pavel Machek [this message]
2002-06-03 19:13 ` do_mmap Thomas 'Dent' Mirlacher
2002-06-03 20:11 ` do_mmap Thomas 'Dent' Mirlacher
2002-06-03 20:25 ` do_mmap Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020603121943.A37@toy.ucw.cz \
--to=pavel@suse.cz \
--cc=dent@cosy.sbg.ac.at \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®