mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Oeser <ingo.oeser@informatik.tu-chemnitz.de>
To: Martin Dalecki <dalecki@evision-ventures.com>
Cc: Jens Axboe <axboe@suse.de>, linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: 2.5.20 RAID5 compile error
Date: Tue, 4 Jun 2002 19:00:07 +0200	[thread overview]
Message-ID: <20020604190007.Q681@nightmaster.csn.tu-chemnitz.de> (raw)
In-Reply-To: <04cf01c20b2d$96097030$f6de11cc@black> <20020604115132.GZ1105@suse.de> <15612.43734.121255.771451@notabene.cse.unsw.edu.au> <20020604115842.GA5143@suse.de> <15612.44897.858819.455679@notabene.cse.unsw.edu.au> <20020604122105.GB1105@suse.de> <20020604123205.GD1105@suse.de> <20020604123856.GE1105@suse.de> <20020604142327.GN1105@suse.de> <3CFCC467.7060702@evision-ventures.com>

Hi Martin,
Hi Jens,
Hi LKML,

On Tue, Jun 04, 2002 at 03:45:11PM +0200, Martin Dalecki wrote:
> Jens - I have noticed some unlikely() tag "optimizations" in
> tcq code too.

unlikely() shows the reader immediately that this is (considered)
a "rare" condition. This might stop janitors optimizing these
cases at all or let people with deeper knowledge check, whether
this is REALLY rare. 

likely() should lead to the analogous actions.

So this is not only a hint for the compiler and I'm very happy to
see this being used and can stand the code clutter caused by
this ;-)

OTOH your point about inline is very valid. I use it only for
code splitting or trivial functions with decisions on compile
time constants. Everything else just bloats the *.o files.

Regards

Ingo Oeser
-- 
Science is what we can tell a computer. Art is everything else. --- D.E.Knuth

  parent reply	other threads:[~2002-06-04 17:10 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-06-03 18:36 Mike Black
2002-06-04 11:51 ` Jens Axboe
2002-06-04 11:56   ` Neil Brown
2002-06-04 11:58     ` Jens Axboe
2002-06-04 12:15       ` Neil Brown
2002-06-04 12:21         ` Jens Axboe
2002-06-04 12:32           ` Jens Axboe
2002-06-04 12:38             ` Jens Axboe
2002-06-04 14:23               ` Jens Axboe
2002-06-04 13:45                 ` Martin Dalecki
2002-06-04 14:55                   ` Jens Axboe
2002-06-04 14:24                     ` Martin Dalecki
2002-06-04 18:22                       ` Horst von Brand
2002-06-05 10:19                       ` Jens Axboe
2002-06-04 17:00                   ` Ingo Oeser [this message]
2002-06-05  1:16               ` Neil Brown
2002-06-05 10:13                 ` Jens Axboe
2002-06-06  2:58                   ` Neil Brown
2002-06-06  5:31                     ` Jens Axboe
2002-06-04 21:48   ` Miles Lane

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020604190007.Q681@nightmaster.csn.tu-chemnitz.de \
    --to=ingo.oeser@informatik.tu-chemnitz.de \
    --cc=axboe@suse.de \
    --cc=dalecki@evision-ventures.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®