From: William Lee Irwin III <wli@holomorphy.com>
To: linux-kernel@vger.kernel.org,
kernel-janitor-discuss@lists.sourceforge.net
Subject: Re: remove magic numbers for fault return codes
Date: Fri, 7 Jun 2002 16:58:00 -0700 [thread overview]
Message-ID: <20020607235800.GB22961@holomorphy.com> (raw)
In-Reply-To: <20020607235259.GP6777@holomorphy.com>
On Fri, Jun 07, 2002 at 04:52:59PM -0700, William Lee Irwin III wrote:
> This patch removes them in favor of defining integer constants with
> mnemonic names and using them as the return codes and in dispatches
> on the return values from handle_mm_fault(), and also removing some of
> the associated comments explaining what the magic numbers mean at
> various points where they were formerly used. In addition two redundant
> variables were removed, a comment was added to the bad_wp_page: label
> to explain to onlookers more of what the printk() there means, and
> failure to match the return code with a value in the various switch()
> statements on the return code was flagged as a BUG() at various points.
This is against 2.5.20, sorry for not mentioning that before.
Cheers,
Bill
prev parent reply other threads:[~2002-06-07 23:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-06-07 23:52 William Lee Irwin III
2002-06-07 23:58 ` William Lee Irwin III [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020607235800.GB22961@holomorphy.com \
--to=wli@holomorphy.com \
--cc=kernel-janitor-discuss@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®