mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: davem@redhat.com, ak@muc.de, kuznet@ms2.inr.ac.ru
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] Networking: ip_gre init corrected
Date: Sat, 8 Jun 2002 21:46:20 +0200	[thread overview]
Message-ID: <20020608214620.A4827@mars.ravnborg.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 382 bytes --]

Hi Networking Maintainers.

While playing around with kbuild I stumbled over this warning:
/net/ipv4/ip_gre.c:123: warning: initialization makes integer from pointer without a cast

Looking into the source it seemed that an init function was not properly
initialised, probarly due to added members in net_device.

Attached patch fixes this, but I did not know how to test it.

	Sam

[-- Attachment #2: ip_gre_init.patch --]
[-- Type: text/plain, Size: 1171 bytes --]

# This is a BitKeeper generated patch for the following project:
# Project Name: Linux kernel tree
# This patch format is intended for GNU patch command version 2.5 or higher.
# This patch includes the following deltas:
#	           ChangeSet	1.471   -> 1.472  
#	   net/ipv4/ip_gre.c	1.7     -> 1.8    
#
# The following is the BitKeeper ChangeSet Log
# --------------------------------------------
# 02/06/08	sam@mars.ravnborg.org	1.472
# net/ipv4/ip_gre.c: Get rid of warning.
# _init function properly initialised.
# --------------------------------------------
#
diff -Nru a/net/ipv4/ip_gre.c b/net/ipv4/ip_gre.c
--- a/net/ipv4/ip_gre.c	Sat Jun  8 21:37:51 2002
+++ b/net/ipv4/ip_gre.c	Sat Jun  8 21:37:51 2002
@@ -120,11 +120,13 @@
 static int ipgre_fb_tunnel_init(struct net_device *dev);
 
 static struct net_device ipgre_fb_tunnel_dev = {
-	"gre0", 0x0, 0x0, 0x0, 0x0, 0, 0, 0, 0, 0, NULL, ipgre_fb_tunnel_init,
+	name:	"gre0",
+	init: 	ipgre_fb_tunnel_init
 };
 
 static struct ip_tunnel ipgre_fb_tunnel = {
-	NULL, &ipgre_fb_tunnel_dev, {0, }, 0, 0, 0, 0, 0, 0, 0, {"gre0", }
+	dev:	&ipgre_fb_tunnel_dev,
+	parms: { name:"gre0"}
 };
 
 /* Tunnel hash table */

             reply	other threads:[~2002-06-08 19:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-06-08 19:46 Sam Ravnborg [this message]
2002-06-09  0:03 ` David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020608214620.A4827@mars.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=ak@muc.de \
    --cc=davem@redhat.com \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®