From: Mikael Pettersson <mikpe@csd.uu.se>
To: manik@cisco.com, mingo@elte.hu
Cc: linux-kernel@vger.kernel.org
Subject: Re: [patch] scheduler bits from 2.5.23-dj1
Date: Thu, 20 Jun 2002 12:11:02 +0200 (MET DST) [thread overview]
Message-ID: <200206201011.MAA10306@harpo.it.uu.se> (raw)
On Thu, 20 Jun 2002 00:26:39 -0700, Manik Raina wrote:
> A small doubt,
> Should'nt this function below return something ?
> set_task_cpu() should return unsigned int but it
> seems to do nothing ....
>
>
>Ingo Molnar wrote:
>> +
>> +static inline unsigned int set_task_cpu(struct task_struct *p, unsigned int cpu)
>> +{
>> +}
My UP CPU number optimisation patch, from which this originates,
made the set_${foo}_cpu() inline 'void'. If for some reason a
return value is needed, just return 0 since that's what the
optimised-away "->cpu = 0" assignment would have had as value.
(The difference is that I had foo=thread_info, but Ingo lifted it
up so foo=task_struct here. I also removed the x86 thread_info cpu
field on UP.)
/Mikael
next reply other threads:[~2002-06-20 10:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-06-20 10:11 Mikael Pettersson [this message]
-- strict thread matches above, loose matches on Subject: below --
2002-06-19 11:23 Linux 2.5.23-dj1 Dave Jones
2002-06-19 23:36 ` [patch] scheduler bits from 2.5.23-dj1 Ingo Molnar
2002-06-19 23:47 ` Robert Love
2002-06-20 0:07 ` Andrea Arcangeli
2002-06-20 0:10 ` Robert Love
2002-06-19 23:47 ` Dave Jones
2002-06-20 17:20 ` William Lee Irwin III
2002-06-20 17:31 ` Ingo Molnar
2002-06-20 17:52 ` William Lee Irwin III
2002-06-20 18:17 ` William Lee Irwin III
2002-06-20 19:26 ` William Lee Irwin III
2002-06-21 1:34 ` William Lee Irwin III
2002-06-19 23:56 ` William Lee Irwin III
2002-06-20 7:26 ` Manik Raina
2002-06-20 13:13 ` Ingo Molnar
2002-06-20 13:34 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200206201011.MAA10306@harpo.it.uu.se \
--to=mikpe@csd.uu.se \
--cc=linux-kernel@vger.kernel.org \
--cc=manik@cisco.com \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®