From: Mikael Pettersson <mikpe@csd.uu.se>
To: ak@suse.de
Cc: linux-kernel@vger.kernel.org
Subject: Re: 2.5.23+ bootflag.c triggers __iounmap: bad address
Date: Fri, 21 Jun 2002 18:44:07 +0200 (MET DST) [thread overview]
Message-ID: <200206211644.SAA14317@harpo.it.uu.se> (raw)
On Fri, 21 Jun 2002 14:43:41 +0200, Andi Kleen wrote:
>> __iounmap: bad address c4800009
>> __iounmap: bad address c4804b8c
>> __iounmap: bad address c4802009
>>
>> These warnings/errors are new since 2.5.23, which makes me
>> suspect something's wrong in the 2.5.23 iounmap changes.
>
>Does this patch fix it?
>
>
>-Andi
>
>
>
>--- linux-2.5.23-work/arch/i386/mm/ioremap.c.~2~ Tue Jun 18 02:13:09 2002
>+++ linux-2.5.23-work/arch/i386/mm/ioremap.c Fri Jun 21 14:42:23 2002
>@@ -213,9 +213,9 @@
> void iounmap(void *addr)
> {
> struct vm_struct *p;
>- if (addr < high_memory)
>+ if (addr <= high_memory)
> return;
>- p = remove_kernel_area(addr);
>+ p = remove_kernel_area(PAGE_MASK & (unsigned long) addr);
> if (!p) {
> printk("__iounmap: bad address %p\n", addr);
> return;
>
Yes, that fixed the problem on the two machines I mentioned.
Thanks.
/Mikael
next reply other threads:[~2002-06-21 16:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-06-21 16:44 Mikael Pettersson [this message]
-- strict thread matches above, loose matches on Subject: below --
2002-06-21 11:56 Mikael Pettersson
2002-06-21 12:23 ` Martin Dalecki
2002-06-21 12:43 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200206211644.SAA14317@harpo.it.uu.se \
--to=mikpe@csd.uu.se \
--cc=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®