mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: mgross <mgross@unix-os.sc.intel.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Linus Torvalds <torvalds@transmeta.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	mark@thegnar.org
Subject: Re: [PATCH] tcore for 2.5.23 kernel
Date: Mon, 24 Jun 2002 11:32:21 -0400	[thread overview]
Message-ID: <200206241824.g5OIOgP30024@unix-os.sc.intel.com> (raw)
In-Reply-To: <20020622143803.GB110@elf.ucw.cz>

Thanks for the input, I'll tweak these things on my next re-base of the patch.

--mgross

On Saturday 22 June 2002 10:38 am, Pavel Machek wrote:
> Hi!
>
> > This patch has been tested on my SMP system and is stable. I would like
> > very much to see this feature added to the 2.5.x kernels and more milage
> > given to it.
>
> Minor comments:
> > +//
> > +// grab all the rq_locks.
> > +// current is the process dumping core
> > +//
>
> Do not use C++ style comments in kernel.
>
> > +				threads[OnCPUCount] = p;
>
> on_cpu_count, this is gnu stile, not java.
> 									Pavel

      reply	other threads:[~2002-06-24 18:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-06-19 13:47 mgross
2002-06-22 14:38 ` Pavel Machek
2002-06-24 15:32   ` mgross [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200206241824.g5OIOgP30024@unix-os.sc.intel.com \
    --to=mgross@unix-os.sc.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark@thegnar.org \
    --cc=pavel@ucw.cz \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®