mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: William Lee Irwin III <wli@holomorphy.com>
To: Erik Andersen <andersen@codepoet.org>, Timo Benk <t_benk@web.de>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: allocate memory in userspace
Date: Tue, 2 Jul 2002 01:37:37 -0700	[thread overview]
Message-ID: <20020702083737.GQ22961@holomorphy.com> (raw)
In-Reply-To: <20020701174913.GA19338@codepoet.org>

On Mon, Jul 01, 2002 at 11:49:13AM -0600, Erik Andersen wrote:
> void *malloc(size_t size)
> {
>     void *result;
>     if (size == 0)
> 	return NULL;
>     result = mmap((void *) 0, size + sizeof(size_t), PROT_READ | PROT_WRITE, 
> 	    MAP_PRIVATE | MAP_ANONYMOUS, 0, 0);
>     if (result == MAP_FAILED)
> 	return 0;
>     * (size_t *) result = size;
>     return(result + sizeof(size_t));
> }

This looks like a very bad idea. Userspace allocators should make some
attempt at avoiding diving into the kernel at every allocation like this.
Also, they should be intelligent enough to get around TASK_UNMAPPED_BASE.
Wilson's allocator survey has an excellent discussion of the issues.
Doug Lea has a better example of a userspace memory allocator.


Cheers,
Bill

  reply	other threads:[~2002-07-02  8:36 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-07-01 17:26 Timo Benk
2002-07-01 17:49 ` Erik Andersen
2002-07-02  8:37   ` William Lee Irwin III [this message]
2002-07-02  8:44     ` William Lee Irwin III
2002-07-02  9:00       ` Erik Andersen
2002-07-01 18:39 ` Calin A. Culianu
2002-07-02  7:51 ` allocate memory in userspace (Answer) Timo Benk
2002-07-02 10:24   ` Timo Benk
2002-07-02 12:19 ` allocate memory in userspace Brian Gerst
     [not found] <20020701172659.GA4431@toshiba.suse.lists.linux.kernel>
2002-07-02  9:30 ` Andi Kleen
2002-07-02 10:21   ` Timo Benk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020702083737.GQ22961@holomorphy.com \
    --to=wli@holomorphy.com \
    --cc=andersen@codepoet.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=t_benk@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®