From: Russell King <rmk@arm.linux.org.uk>
To: Douglas Gilbert <dougg@torque.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: dead keyboard in lk 2.5.25
Date: Sun, 7 Jul 2002 16:45:54 +0100 [thread overview]
Message-ID: <20020707164554.B15933@flint.arm.linux.org.uk> (raw)
In-Reply-To: <3D284E20.D5D00F99@torque.net>; from dougg@torque.net on Sun, Jul 07, 2002 at 10:20:16AM -0400
On Sun, Jul 07, 2002 at 10:20:16AM -0400, Douglas Gilbert wrote:
> --- linux/drivers/input/serio/i8042.c Sat Jul 6 08:57:35 2002
> +++ linux/drivers/input/serio/i8042.c2525fix Sun Jul 7 09:52:50 2002
> @@ -269,8 +269,11 @@
> */
>
> if (request_irq(values->irq, i8042_interrupt, 0, "i8042", NULL)) {
> - printk(KERN_ERR "i8042.c: Can't get irq %d for %s\n", values->irq, values->name);
> - return -1;
> + free_irq(values->irq, NULL);
> + if (request_irq(values->irq, i8042_interrupt, 0, "i8042", NULL)) {
> + printk(KERN_ERR "i8042.c: Can't get irq %d for %s\n", values->irq, values->name);
> + return -1;
> + }
> }
>
> /*
Hmm, interesting concept. "If someone else is using my resource, I'll
free it for them, and re-claim it". It sounds very much like a hack
rather than a fix to me.
I'd guess the real solution would be to stop pc_keyb being initialised
when you're trying to use i8042.c. Vojtech?
--
Russell King (rmk@arm.linux.org.uk) The developer of ARM Linux
http://www.arm.linux.org.uk/personal/aboutme.html
next prev parent reply other threads:[~2002-07-07 15:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-07 14:20 Douglas Gilbert
2002-07-07 15:45 ` Russell King [this message]
2002-07-07 21:26 ` Vojtech Pavlik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020707164554.B15933@flint.arm.linux.org.uk \
--to=rmk@arm.linux.org.uk \
--cc=dougg@torque.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®