From: Tom Rini <trini@kernel.crashing.org>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [PATCH] Fix drivers/media/video/videodev.c on !MODULE case
Date: Tue, 9 Jul 2002 12:42:26 -0700 [thread overview]
Message-ID: <20020709194226.GR695@opus.bloom.county> (raw)
Currently videodev_proc_destroy() isn't always compiled in when used.
Right now it's compiled in based on MODULE && CONFIG_PROC_FS &&
CONFIG_VIDEO_PROC_FS. The two problems here the part of the file where
videodev_proc_destroy resides is already protected by CONFIG_PROC_FS &&
CONFIG_VIDEO_PROC_FS. The second problem is that
videodev_proc_destroy() isn't module specific, and is called on
CONFIG_PROC_FS && CONFIG_VIDEO_PROC_FS.
This removes the unnecessary tests and updates a comment as well to
reflect what's being tested.
--
Tom Rini (TR1265)
http://gate.crashing.org/~trini/
===== drivers/media/video/videodev.c 1.13 vs edited =====
--- 1.13/drivers/media/video/videodev.c Wed Apr 3 17:05:11 2002
+++ edited/drivers/media/video/videodev.c Tue Jul 9 12:38:30 2002
@@ -288,8 +288,6 @@
video_dev_proc_entry->owner = THIS_MODULE;
}
-#ifdef MODULE
-#if defined(CONFIG_PROC_FS) && defined(CONFIG_VIDEO_PROC_FS)
static void videodev_proc_destroy(void)
{
if (video_dev_proc_entry != NULL)
@@ -298,8 +296,6 @@
if (video_proc_entry != NULL)
remove_proc_entry("video", &proc_root);
}
-#endif
-#endif
static void videodev_proc_create_dev (struct video_device *vfd, char *name)
{
@@ -344,7 +340,7 @@
}
}
-#endif /* CONFIG_VIDEO_PROC_FS */
+#endif /* CONFIG_VIDEO_PROC_FS && CONFIG_VIDEO_PROC_FS */
extern struct file_operations video_fops;
reply other threads:[~2002-07-09 19:40 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020709194226.GR695@opus.bloom.county \
--to=trini@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®