mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Thunder from the hill <thunder@ngforever.de>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Richard Gooch <rgooch@ras.ucalgary.ca>
Subject: Re: Compile warning in fs/partitions/check.c
Date: Fri, 12 Jul 2002 16:14:06 -0700	[thread overview]
Message-ID: <20020712231406.GB11995@kroah.com> (raw)
In-Reply-To: <Pine.LNX.4.44.0207121704210.3421-100000@hawkeye.luckynet.adm>

On Fri, Jul 12, 2002 at 05:05:23PM -0600, Thunder from the hill wrote:
> Hi,
> 
> Possible fix for the show ones seems:
> 
> Index: include/linux/driverfs_fs.h
> ===================================================================
> RCS file: /var/cvs/thunder-2.5/include/linux/driverfs_fs.h,v
> retrieving revision 1.2
> diff -p -u -r1.2 driverfs_fs.h
> --- include/linux/driverfs_fs.h	9 Jul 2002 12:15:28 -0000	1.2
> +++ include/linux/driverfs_fs.h	12 Jul 2002 23:04:08 -0000
> @@ -41,8 +41,8 @@ struct driver_dir_entry {
>  
>  struct device;
>  
> -typedef ssize_t (*driverfs_show)(void * obj, char * buf, size_t count, loff_t off);
> -typedef ssize_t (*driverfs_store)(void * obj, const char * buf, size_t count, loff_t off);
> +typedef ssize_t (*driverfs_show)(struct device * obj, char * buf, size_t count, loff_t off);
> +typedef ssize_t (*driverfs_store)(struct device * obj, const char * buf, size_t count, loff_t off);

No, this patch is incorrect.  See Pat's patch that was posted a few
days ago.

And I don't think Richard really wants to be bothered with driverfs
questions :)

thanks,

greg k-h

  reply	other threads:[~2002-07-12 23:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-07-12 22:46 Thunder from the hill
2002-07-12 23:05 ` Thunder from the hill
2002-07-12 23:14   ` Greg KH [this message]
2002-07-12 23:20     ` Thunder from the hill
2002-07-13  3:17       ` Patrick Mochel
2002-07-13  3:16 ` Patrick Mochel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020712231406.GB11995@kroah.com \
    --to=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rgooch@ras.ucalgary.ca \
    --cc=thunder@ngforever.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®